From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, jesse.brandeburg@intel.com
Subject: Re: [net-next-2.6 PATCH 1/5] ixgbe: fix link down initial state
Date: Mon, 20 Apr 2009 02:04:59 -0700 (PDT) [thread overview]
Message-ID: <20090420.020459.262772235.davem@davemloft.net> (raw)
In-Reply-To: <20090418064427.4328.45811.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 17 Apr 2009 23:44:27 -0700
> All the intel wired ethernet drivers were calling netif_carrier_off
> and netif_stop_queue (or variants) before calling register_netdevice
>
> This is incorrect behavior as was pointed out by davem, and causes
> ifconfig and friends to report a strange state before first link
> after the driver was loaded, since without a netif_carrier_off, the stack
> assumes carrier_on, but before register_netdev, netlink messages are not
> sent out telling link state.
All 5 patches applied, thanks!
FWIW, this is definitely a case where I would have found it just as
appropriate to post one single patch for this. But that's just me :-)
next prev parent reply other threads:[~2009-04-20 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 6:44 [net-next-2.6 PATCH 1/5] ixgbe: fix link down initial state Jeff Kirsher
2009-04-18 6:44 ` [net-next-2.6 PATCH 2/5] ixgb: " Jeff Kirsher
2009-04-18 6:44 ` [net-next-2.6 PATCH 3/5] igb: fix link down inital state Jeff Kirsher
2009-04-18 6:44 ` [net-next-2.6 PATCH 4/5] e1000e: indicate link down at load Jeff Kirsher
2009-04-18 6:44 ` [net-next-2.6 PATCH 5/5] e1000: init link state correctly Jeff Kirsher
2009-04-20 9:04 ` David Miller [this message]
2009-04-20 9:15 ` [net-next-2.6 PATCH 1/5] ixgbe: fix link down initial state Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420.020459.262772235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).