From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: jianjun@zeuux.org, jon.lin@vatics.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.29.1 1/1] 8139too: fix HW initial flow
Date: Wed, 22 Apr 2009 00:44:32 -0700 (PDT) [thread overview]
Message-ID: <20090422.004432.227765146.davem@davemloft.net> (raw)
In-Reply-To: <49EDA040.5040600@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 21 Apr 2009 12:30:24 +0200
> Amos Kong a écrit :
>> ...
>> While ifconfig eth0 up kernel calls open() of 8139 driver(8139too.c).
>> In rtl8139_hw_start() of rtl8139_open(), 8139 driver enable RX before setting up the DMA
>> buffer address. In this interval where RX was enabled and DMA buffer address is not yet set
>> up, any incoming broadcast packet would be send to a strange physical address:
>> 0x003e8800 which is the default value of DMA buffer address.
>> Unfortunately, this address is used by Linux kernel. So kernel panics.
>> This patch fix it by setting up DMA buffer address before RX enabled and everything is fine
>> even under broadcast packets attack.
>>
>> Signed-off-by: Jonathan Lin <jon.lin@vatics.com>
>> Signed-off-by: Amos Kong <jianjun@zeuux.org>
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>
> Thanks Amos and Jonathan
Applied, thanks everyone.
next prev parent reply other threads:[~2009-04-22 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 12:58 [PATCH 2.6.29.1 1/1] 8139too: fix HW initial flow jon.lin
2009-04-20 13:28 ` Amos Kong
2009-04-21 8:52 ` David Miller
2009-04-21 9:48 ` Amos Kong
2009-04-21 10:09 ` jon.lin
2009-04-21 10:34 ` Eric Dumazet
2009-04-21 10:30 ` Eric Dumazet
2009-04-22 7:44 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-21 10:13 [PATCH 2.6.29.1 1/1]8139too:fix " User Tzungder
2009-04-19 10:16 [PATCH 2.6.29.1 1/1] 8139too: fix " Tzungder Lin
2009-04-19 11:22 ` Eric Dumazet
2009-04-20 1:54 ` Tzungder Lin
2009-04-20 10:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422.004432.227765146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=jianjun@zeuux.org \
--cc=jon.lin@vatics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).