* ath5k irq warning message
@ 2009-04-22 21:56 Ben Greear
2009-04-23 12:06 ` Bob Copeland
0 siblings, 1 reply; 3+ messages in thread
From: Ben Greear @ 2009-04-22 21:56 UTC (permalink / raw)
To: NetDev
I'm working on debugging some sort of live-lock related to irqs
in ath5k with lots of virtual stations.
I notice this code in the ath5k_intr method.
Won't counter be -1 if you break out of this due to the 'counter-- > 0'
clause?
If so, then that warning won't be printed regardless...
} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
if (unlikely(!counter))
ATH5K_WARN(sc, "too many interrupts, giving up for now\n");
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath5k irq warning message
2009-04-22 21:56 ath5k irq warning message Ben Greear
@ 2009-04-23 12:06 ` Bob Copeland
2009-04-23 16:27 ` Ben Greear
0 siblings, 1 reply; 3+ messages in thread
From: Bob Copeland @ 2009-04-23 12:06 UTC (permalink / raw)
To: Ben Greear; +Cc: NetDev
On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
> I notice this code in the ath5k_intr method.
>
> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
> clause?
>
> } while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
Good catch, I guess it should be --counter...
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath5k irq warning message
2009-04-23 12:06 ` Bob Copeland
@ 2009-04-23 16:27 ` Ben Greear
0 siblings, 0 replies; 3+ messages in thread
From: Ben Greear @ 2009-04-23 16:27 UTC (permalink / raw)
To: Bob Copeland; +Cc: NetDev
Bob Copeland wrote:
> On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
>> I notice this code in the ath5k_intr method.
>>
>> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
>> clause?
>>
>> } while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
>
> Good catch, I guess it should be --counter...
That works for me.
Seems the root cause of my problem might have been fixed already
by the patch to turn off BMISS irqs, btw...about to start
testing that now.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-23 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-22 21:56 ath5k irq warning message Ben Greear
2009-04-23 12:06 ` Bob Copeland
2009-04-23 16:27 ` Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).