* [patch] net/ps3: Fix wireless AP connect error handling
@ 2009-03-30 18:04 Geoff Levand
2009-04-23 22:46 ` Geoff Levand
0 siblings, 1 reply; 4+ messages in thread
From: Geoff Levand @ 2009-03-30 18:04 UTC (permalink / raw)
To: linville, jgarzik; +Cc: netdev, linux-wireless, Masakazu Mokuno
From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,
Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
drivers/net/ps3_gelic_wireless.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2101,6 +2101,9 @@ static int gelic_wl_associate_bss(struct
if (ret) {
pr_debug("%s: WEP/WPA setup failed %d\n", __func__,
ret);
+ ret = -EPERM;
+ gelic_wl_send_iwap_event(wl, NULL);
+ goto out;
}
/* start association */
^ permalink raw reply [flat|nested] 4+ messages in thread* [patch] net/ps3: Fix wireless AP connect error handling
2009-03-30 18:04 [patch] net/ps3: Fix wireless AP connect error handling Geoff Levand
@ 2009-04-23 22:46 ` Geoff Levand
2009-04-24 20:14 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: Geoff Levand @ 2009-04-23 22:46 UTC (permalink / raw)
To: linville; +Cc: jgarzik, netdev, linux-wireless, Masakazu Mokuno
From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,
Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Hi John,
I didn't see this get merged in to 2.6.30 yet. Could you let me know the status?
-Geoff
drivers/net/ps3_gelic_wireless.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2101,6 +2101,9 @@ static int gelic_wl_associate_bss(struct
if (ret) {
pr_debug("%s: WEP/WPA setup failed %d\n", __func__,
ret);
+ ret = -EPERM;
+ gelic_wl_send_iwap_event(wl, NULL);
+ goto out;
}
/* start association */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] net/ps3: Fix wireless AP connect error handling
2009-04-23 22:46 ` Geoff Levand
@ 2009-04-24 20:14 ` John W. Linville
[not found] ` <20090424201446.GD3309-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: John W. Linville @ 2009-04-24 20:14 UTC (permalink / raw)
To: Geoff Levand; +Cc: jgarzik, netdev, linux-wireless, Masakazu Mokuno
On Thu, Apr 23, 2009 at 03:46:17PM -0700, Geoff Levand wrote:
> From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
>
> This patch fixes the bug that the driver tries to continue to
> connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> Hi John,
>
> I didn't see this get merged in to 2.6.30 yet. Could you let me know the status?
>
> -Geoff
I have it queued for 2.6.31. Does it cause a crash or other problem
serious enough to merit pushing it for 2.6.30?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-24 20:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-30 18:04 [patch] net/ps3: Fix wireless AP connect error handling Geoff Levand
2009-04-23 22:46 ` Geoff Levand
2009-04-24 20:14 ` John W. Linville
[not found] ` <20090424201446.GD3309-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-04-24 20:58 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).