From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org
Subject: Re: vlan: update vlan carrier state for admin up/down
Date: Sat, 25 Apr 2009 18:06:28 -0700 (PDT) [thread overview]
Message-ID: <20090425.180628.109371724.davem@davemloft.net> (raw)
In-Reply-To: <49F1DE6F.1030606@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Fri, 24 Apr 2009 17:44:47 +0200
> vlan: update vlan carrier state for admin up/down
>
> Currently, the VLAN event handler does not adjust the VLAN
> device's carrier state when the real device or the VLAN device is set
> administratively up or down.
>
> The following patch adds a transfer of operating state from the
> real device to the VLAN device when the real device is administratively
> set up or down, and sets the carrier state up or down during init, open
> and close of the VLAN device.
>
> This permits observers above the VLAN device that care about the
> carrier state (bonding's link monitor, for example) to receive updates
> for administrative changes by more closely mimicing the behavior of real
> devices.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
I've applied this to net-2.6, thanks!
I realize there are some more issues to deal with wrt. the
comments Ben made. And I eagerly await patches for that :)
prev parent reply other threads:[~2009-04-26 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 15:44 vlan: update vlan carrier state for admin up/down Patrick McHardy
2009-04-24 16:39 ` Ben Greear
2009-04-25 0:31 ` Jay Vosburgh
2009-04-26 19:58 ` Ben Greear
2009-04-27 23:55 ` Jay Vosburgh
2009-04-28 1:36 ` David Miller
2009-04-30 7:48 ` Ben Greear
2009-05-05 12:41 ` Patrick McHardy
2009-04-26 1:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090425.180628.109371724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).