From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] gianfar: irq_of_parse_and_map() error unnoticed
Date: Mon, 27 Apr 2009 03:11:16 -0700 (PDT) [thread overview]
Message-ID: <20090427.031116.43598009.davem@davemloft.net> (raw)
In-Reply-To: <49F0649C.8030908@gmail.com>
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 23 Apr 2009 14:52:44 +0200
> Not sure which irq_of_parse_and_map() is used, but I found definitions here:
>
> vi arch/microblaze/kernel/irq.c +23
> vi arch/powerpc/kernel/irq.c +727
> vi arch/sparc/kernel/of_device_32.c +33
> vi arch/sparc/kernel/of_device_64.c +59
>
> They either return 0 or NO_IRQ - either defined 0, -1, 255 or INT_MAX.
> ------------------------------>8-------------8<---------------------------------
> priv->interruptTransmit, -Receive and -Error are unsigned, so the error path
> wasn't taken when irq_of_parse_and_map() returned an incorrect irq.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
This test is way too convoluted for my taste.
I would rather that the implementations of this interface
use a consistent value for errors. Preferrably NO_IRQ.
Not applied.
next prev parent reply other threads:[~2009-04-27 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 12:52 [PATCH] gianfar: irq_of_parse_and_map() error unnoticed Roel Kluin
2009-04-27 10:11 ` David Miller [this message]
2009-04-27 11:05 ` [PATCH 2/2] " Roel Kluin
2009-04-27 19:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427.031116.43598009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).