netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: anton@samba.org
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Limit size of route cache hash table
Date: Mon, 27 Apr 2009 05:40:24 -0700 (PDT)	[thread overview]
Message-ID: <20090427.054024.94955211.davem@davemloft.net> (raw)
In-Reply-To: <20090427115007.GC15891@kryten>

From: Anton Blanchard <anton@samba.org>
Date: Mon, 27 Apr 2009 21:50:07 +1000

> Right now we have no upper limit on the size of the route cache hash table.
> On a 128GB POWER6 box it ends up as 32MB:
> 
>     IP route cache hash table entries: 4194304 (order: 9, 33554432 bytes)
> 
> It would be nice to cap this for memory consumption reasons, but a massive
> hashtable also causes a significant spike when measuring OS jitter.
> 
> With a 32MB hashtable and 4 million entries, rt_worker_func is taking
> 5 ms to complete. On another system with more memory it's taking 14 ms.
> Even though rt_worker_func does call cond_sched() to limit its impact,
> in an HPC environment we want to keep all sources of OS jitter to a minimum.
> 
> With the patch applied we limit the number of entries to 512k which
> can still be overriden by using the rt_entries boot option:
> 
>     IP route cache hash table entries: 524288 (order: 6, 4194304 bytes)
> 
> With this patch rt_worker_func now takes 0.460 ms on the same system.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Acked-by: Eric Dumazet <dada1@cosmosbay.com>

Applied, thanks!

  reply	other threads:[~2009-04-27 12:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27  3:04 [PATCH] Limit size of route cache hash table Anton Blanchard
2009-04-27  5:17 ` Eric Dumazet
2009-04-27  5:47   ` Anton Blanchard
2009-04-27  6:12     ` Eric Dumazet
2009-04-27  6:36       ` David Miller
2009-04-27  6:47         ` Eric Dumazet
2009-04-27 11:44           ` Anton Blanchard
2009-04-27 11:50           ` Anton Blanchard
2009-04-27 12:40             ` David Miller [this message]
2009-04-27  6:35     ` David Miller
2009-04-27  6:11 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090427.054024.94955211.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anton@samba.org \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).