From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] powerpc: convert mace to netdev_ops Date: Mon, 27 Apr 2009 05:42:58 -0700 (PDT) Message-ID: <20090427.054258.16622932.davem@davemloft.net> References: <20090426155708.GA23159@ime.usp.br> <20090426.230648.254087966.davem@davemloft.net> <20090427121633.GA29608@ime.usp.br> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: rbrito@ime.usp.br Return-path: In-Reply-To: <20090427121633.GA29608@ime.usp.br> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org List-Id: netdev.vger.kernel.org From: Rog=E9rio Brito Date: Mon, 27 Apr 2009 09:16:33 -0300 > Is this anything close to what needs to be done? It's not without > failures, because the function mace_set_timeout receives a pointer to a > struct net_device, but is marked inline and is used by mace_tx_timeout, > which receives an unsigned long (which calls mace_set_timeout). > = > Perhaps it would be a case of removing the inline hint to the compiler? > I guess that BenH or Paul could comment here better... > = > Signed-off-by: Rog=E9rio Brito You can fix the mace_set_timeout() function arguments by having a helper function that simply wraps around it and provides the second expection of argument types. Your patch is also wrong, it's missing a lot of netdev_ops entries that are implicitly obtained via alloc_etherdev(), namely: .ndo_change_mtu =3D eth_change_mtu, .ndo_set_mac_address =3D eth_mac_addr, .ndo_validate_addr =3D eth_validate_addr,