From: Andrew Morton <akpm@linux-foundation.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: jgarzik@pobox.com, manfred@colorfullife.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: tx timeout fix
Date: Mon, 27 Apr 2009 11:59:45 -0700 [thread overview]
Message-ID: <20090427115945.d736ac1f.akpm@linux-foundation.org> (raw)
In-Reply-To: <49F361E4.4050605@nvidia.com>
On Sat, 25 Apr 2009 15:17:56 -0400
Ayaz Abdulla <aabdulla@nvidia.com> wrote:
> This patch fixes the tx_timeout() to properly handle the clean up of the
> tx ring. It also sets the tx put pointer back to the correct position to
> be in sync with HW.
It's unclear (to me) what the real-world impact of this bugfix is.
There isn't enough information here to decide whether the fix should be
backported to 2.6.29 (and earlier?). What is the user-visible
behaviour change? What hardware does it affect? What is the risk that
the change will inadvertently break other setups? etc.
Please always provide such information in the changelogs.
prev parent reply other threads:[~2009-04-27 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 19:17 [PATCH] forcedeth: tx timeout fix Ayaz Abdulla
2009-04-26 1:16 ` David Miller
2009-04-27 18:59 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427115945.d736ac1f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aabdulla@nvidia.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).