netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* inet_diag: Remove dup assignments
@ 2009-04-28 13:56 Arnaldo Carvalho de Melo
  2009-04-28 15:03 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-04-28 13:56 UTC (permalink / raw)
  To: David Miller; +Cc: Linux Networking Development Mailing List

These are later assigned to other values without being used meanwhile.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index 588a779..b0b2735 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -198,8 +198,6 @@ static int inet_twsk_diag_fill(struct inet_timewait_sock *tw,
 		tmo = 0;
 
 	r->idiag_family	      = tw->tw_family;
-	r->idiag_state	      = tw->tw_state;
-	r->idiag_timer	      = 0;
 	r->idiag_retrans      = 0;
 	r->id.idiag_if	      = tw->tw_bound_dev_if;
 	r->id.idiag_cookie[0] = (u32)(unsigned long)tw;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: inet_diag: Remove dup assignments
  2009-04-28 13:56 inet_diag: Remove dup assignments Arnaldo Carvalho de Melo
@ 2009-04-28 15:03 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-28 15:03 UTC (permalink / raw)
  To: acme; +Cc: netdev

From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Tue, 28 Apr 2009 10:56:36 -0300

> These are later assigned to other values without being used meanwhile.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-28 15:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-28 13:56 inet_diag: Remove dup assignments Arnaldo Carvalho de Melo
2009-04-28 15:03 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).