From: David Miller <davem@davemloft.net>
To: dvomlehn@cisco.com
Cc: netdev@vger.kernel.org
Subject: Re: [Patch 1/1][RFC] NETDEV: Find network bugs by validating the sk_buff state
Date: Wed, 29 Apr 2009 14:53:38 -0700 (PDT) [thread overview]
Message-ID: <20090429.145338.149717676.davem@davemloft.net> (raw)
In-Reply-To: <20090429151440.GA14266@cuplxvomd02.corp.sa.net>
From: David VomLehn <dvomlehn@cisco.com>
Date: Wed, 29 Apr 2009 08:14:40 -0700
> On Tue, Apr 28, 2009 at 10:30:58PM -0700, David Miller wrote:
>>
>> Sorry, for this to be useful distributions are going to turn it on by
>> default, and adding 24 bytes to struct sk_buff on 64-bit when we're
>> trying everything in our power to make it smaller rather than larger
>> is not acceptable.
>
> That's like saying that any of the kernel debugging options have to be on
> by default. I expect that most folks won't want this on unless they are
> looking for a bug.
We don't have networking buffer structure elements that implement
debugging, and it's for a reason.
>> It's a useful change, something to keep in one's back pocket when
>> debugging something, but not for upstream, sorry.
>
> Right. This is why it depends on KERNEL_DEBUG and why it is off by default.
All of this is moot if distributions decide to start turning this
on, and from my experience they will.
next prev parent reply other threads:[~2009-04-29 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 4:05 [Patch 1/1][RFC] NETDEV: Find network bugs by validating the sk_buff state David VomLehn
2009-04-29 5:30 ` David Miller
2009-04-29 15:14 ` David VomLehn
2009-04-29 21:53 ` David Miller [this message]
2009-04-29 22:28 ` David VomLehn
2009-04-29 22:44 ` David Miller
2009-04-30 16:32 ` David VomLehn
2009-04-30 16:46 ` David Miller
2009-04-30 17:59 ` David VomLehn
2009-04-30 18:05 ` David Miller
2009-04-30 18:23 ` David VomLehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429.145338.149717676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvomlehn@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).