* [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’
@ 2009-04-30 6:06 Sergey Senozhatsky
2009-05-01 16:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Senozhatsky @ 2009-04-30 6:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: netdev
Trivial: fixing gcc 4.4 compiler warning:
drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’:
drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
---
diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
index e1bd690..4f68aeb 100644
--- a/drivers/net/cxgb3/t3_hw.c
+++ b/drivers/net/cxgb3/t3_hw.c
@@ -3779,7 +3779,7 @@ int t3_prep_adapter(struct adapter *adapter, const struct adapter_info *ai,
adapter->params.info = ai;
adapter->params.nports = ai->nports0 + ai->nports1;
- adapter->params.chan_map = !!ai->nports0 | (!!ai->nports1 << 1);
+ adapter->params.chan_map = (!!ai->nports0) | (!!ai->nports1 << 1);
adapter->params.rev = t3_read_reg(adapter, A_PL_REV);
/*
* We used to only run the "adapter check task" once a second if
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’
2009-04-30 6:06 [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ Sergey Senozhatsky
@ 2009-05-01 16:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-01 16:15 UTC (permalink / raw)
To: sergey.senozhatsky; +Cc: akpm, netdev
From: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
Date: Thu, 30 Apr 2009 09:06:16 +0300
> Trivial: fixing gcc 4.4 compiler warning:
> drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’:
> drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-01 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-30 6:06 [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’ Sergey Senozhatsky
2009-05-01 16:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).