From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: andrew@whydna.net, jelaas@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: skb_tx_hash() improvements
Date: Fri, 01 May 2009 09:17:47 -0700 (PDT) [thread overview]
Message-ID: <20090501.091747.240476627.davem@davemloft.net> (raw)
In-Reply-To: <49FAC112.6090808@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Fri, 01 May 2009 11:29:54 +0200
> - } else if (skb->sk && skb->sk->sk_hash) {
> + /*
> + * Try to avoid an expensive divide, for symmetric setups :
> + * number of tx queues of output device ==
> + * number of rx queues of incoming device
> + */
> + if (hash >= dev->real_num_tx_queues)
> + hash %= dev->real_num_tx_queues;
> + return hash;
> + }
Subtraction in a while() loop is almost certainly a lot
faster.
next prev parent reply other threads:[~2009-05-01 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 23:00 tx queue hashing hot-spots and poor performance (multiq, ixgbe) Andrew Dickinson
2009-04-30 9:07 ` Jens Låås
2009-04-30 9:24 ` David Miller
2009-04-30 10:51 ` Jens Låås
2009-04-30 11:05 ` David Miller
2009-04-30 14:04 ` Andrew Dickinson
2009-04-30 14:08 ` David Miller
2009-04-30 23:53 ` Andrew Dickinson
2009-05-01 4:19 ` Andrew Dickinson
2009-05-01 7:32 ` Eric Dumazet
2009-05-01 7:47 ` Eric Dumazet
2009-05-01 6:14 ` Eric Dumazet
2009-05-01 6:19 ` Andrew Dickinson
2009-05-01 6:40 ` Eric Dumazet
2009-05-01 7:23 ` Andrew Dickinson
2009-05-01 7:31 ` Eric Dumazet
2009-05-01 7:34 ` Andrew Dickinson
2009-05-01 21:37 ` Brandeburg, Jesse
2009-05-01 8:29 ` [PATCH] net: skb_tx_hash() improvements Eric Dumazet
2009-05-01 8:52 ` Eric Dumazet
2009-05-01 9:29 ` Eric Dumazet
2009-05-01 16:17 ` David Miller [this message]
2009-05-03 21:44 ` David Miller
2009-05-04 6:12 ` Eric Dumazet
2009-05-01 16:08 ` tx queue hashing hot-spots and poor performance (multiq, ixgbe) David Miller
2009-05-01 16:48 ` Eric Dumazet
2009-05-01 17:22 ` David Miller
2009-05-01 10:20 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501.091747.240476627.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@whydna.net \
--cc=dada1@cosmosbay.com \
--cc=jelaas@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).