From: David Miller <davem@davemloft.net>
To: robert.w.love@intel.com
Cc: James.Bottomley@HansenPartnership.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Add the FCoE Initialization Protocol ethertype
Date: Fri, 01 May 2009 15:56:01 -0700 (PDT) [thread overview]
Message-ID: <20090501.155601.205697782.davem@davemloft.net> (raw)
In-Reply-To: <273D38FBE7C6FE46A1689FCD014A0B8B495C012C@azsmsx505.amr.corp.intel.com>
From: "Love, Robert W" <robert.w.love@intel.com>
Date: Fri, 1 May 2009 15:53:32 -0700
> The FIP implementation is upstream, in drivers/scsi/libfcoe.c.
> There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE
> and I'd rather move it to the propper location.
Then add that local definition removal to your patch so there is
no mystery about what this is used for.
> I can refresh this patch to include the fc_fip.h removal and you and
> James can decide who takes the patch if that's a better aproach.
That works much better, and to avoid merge issues you can send it
via James with my pre-ack:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-05-01 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 18:55 [PATCH] net: Add the FCoE Initialization Protocol ethertype Robert Love
2009-05-01 22:04 ` David Miller
2009-05-01 22:53 ` Love, Robert W
2009-05-01 22:56 ` David Miller [this message]
2009-05-01 22:57 ` Love, Robert W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501.155601.205697782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=netdev@vger.kernel.org \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).