From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, jesse.brandeburg@intel.com
Subject: Re: [net-2.6 PATCH] e1000: fix virtualization bug
Date: Mon, 04 May 2009 21:31:04 -0700 (PDT) [thread overview]
Message-ID: <20090504.213104.13037490.davem@davemloft.net> (raw)
In-Reply-To: <20090504211941.10922.95964.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 04 May 2009 14:19:42 -0700
> a recent fix to e1000 (commit 15b2bee2) caused KVM/QEMU/VMware based
> virtualized e1000 interfaces to begin failing when resetting.
>
> This is because the driver in a virtual environment doesn't
> get to run instructions *AT ALL* when an interrupt is asserted.
> The interrupt code runs immediately and this recent bug fix
> allows an interrupt to be possible when the interrupt handler
> will reject it (due to the new code), when being called from
> any path in the driver that holds the E1000_RESETTING flag.
>
> the driver should use the __E1000_DOWN flag instead of the
> __E1000_RESETTING flag to prevent interrupt execution
> while reconfiguring the hardware.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
prev parent reply other threads:[~2009-05-05 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 21:19 [net-2.6 PATCH] e1000: fix virtualization bug Jeff Kirsher
2009-05-05 4:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504.213104.13037490.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).