From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Breno Leitao <leitao@linux.vnet.ibm.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next-2.6 PATCH 4/5] ixgbe: Return PCI_ERS_RESULT_DISCONNECT when bus is disabled
Date: Wed, 06 May 2009 13:44:26 -0700 [thread overview]
Message-ID: <20090506204425.18071.23427.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090506204317.18071.96421.stgit@localhost.localdomain>
From: Breno Leitao <leitao@linux.vnet.ibm.com>
According to the "PCI Error Recovery" document, if after a recovery,
the bus is disabled, the error_detected function should return
PCI_ERS_RESULT_DISCONNECT. Actually ixgbe error_detected function is
always returning PCI_ERS_RESULT_NEED_RESET, even if the bus is in failure.
This patch just check if the bus is disabled and then returns
PCI_ERS_RESULT_DISCONNET.
Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 2c70fa0..dd56adb 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -5145,6 +5145,9 @@ static pci_ers_result_t ixgbe_io_error_detected(struct pci_dev *pdev,
netif_device_detach(netdev);
+ if (state == pci_channel_io_perm_failure)
+ return PCI_ERS_RESULT_DISCONNECT;
+
if (netif_running(netdev))
ixgbe_down(adapter);
pci_disable_device(pdev);
next prev parent reply other threads:[~2009-05-06 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:43 [net-next-2.6 PATCH 1/5] ixgbe: make q_vectors dynamic to reduce netdev size Jeff Kirsher
2009-05-06 20:43 ` [net-next-2.6 PATCH 2/5] ixgbe: skb_record_rx_queue should record rx queue instead of vector Jeff Kirsher
2009-05-06 20:44 ` [net-next-2.6 PATCH 3/5] ixgbe: remove ixgbe_napi_add/del_all references Jeff Kirsher
2009-05-06 20:44 ` Jeff Kirsher [this message]
2009-05-06 20:44 ` [net-next-2.6 PATCH 5/5] ixgbe: Proposed PARCH PCIE legacy I/O port free intel 10Gb NIC driver Jeff Kirsher
2009-05-06 22:38 ` [net-next-2.6 PATCH 1/5] ixgbe: make q_vectors dynamic to reduce netdev size David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506204425.18071.23427.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox