* [net-next-2.6 PATCH 2/5] ixgbe: set queue0 for srrctl configuration correctly for DCB
2009-05-07 20:38 [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL Jeff Kirsher
@ 2009-05-07 20:39 ` Jeff Kirsher
2009-05-07 21:56 ` David Miller
2009-05-07 20:39 ` [net-next-2.6 PATCH 3/5] ixgbe: Enable L2 header split in 82599 Jeff Kirsher
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Jeff Kirsher @ 2009-05-07 20:39 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Alexander Duyck, Jeff Kirsher
From: Alexander Duyck <alexander.h.duyck@intel.com>
The current configuration is not setting queue 0 correctly for DCB
configurations. As a result unconfigured queues are being used to setup
the SRRCTL register rx buffer len sizes.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 4c38d51..d64a2d7 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1740,7 +1740,18 @@ static void ixgbe_configure_srrctl(struct ixgbe_adapter *adapter, int index)
unsigned long mask;
if (adapter->hw.mac.type == ixgbe_mac_82599EB) {
- queue0 = index;
+ if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
+ int dcb_i = adapter->ring_feature[RING_F_DCB].indices;
+ if (dcb_i == 8)
+ queue0 = index >> 4;
+ else if (dcb_i == 4)
+ queue0 = index >> 5;
+ else
+ dev_err(&adapter->pdev->dev, "Invalid DCB "
+ "configuration\n");
+ } else {
+ queue0 = index;
+ }
} else {
mask = (unsigned long) adapter->ring_feature[RING_F_RSS].mask;
queue0 = index & mask;
^ permalink raw reply related [flat|nested] 10+ messages in thread* [net-next-2.6 PATCH 3/5] ixgbe: Enable L2 header split in 82599
2009-05-07 20:38 [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL Jeff Kirsher
2009-05-07 20:39 ` [net-next-2.6 PATCH 2/5] ixgbe: set queue0 for srrctl configuration correctly for DCB Jeff Kirsher
@ 2009-05-07 20:39 ` Jeff Kirsher
2009-05-07 21:56 ` David Miller
2009-05-07 20:39 ` [net-next-2.6 PATCH 4/5] ixgbe: fix failing to log fan failures Jeff Kirsher
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Jeff Kirsher @ 2009-05-07 20:39 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Yi Zou, Jeff Kirsher
From: Yi Zou <yi.zou@intel.com>
This enables L2 header split when packet split is enabled for 82599.
Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 3 ++-
drivers/net/ixgbe/ixgbe_type.h | 1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index d64a2d7..01d8b6b 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1818,7 +1818,8 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter)
u32 psrtype = IXGBE_PSRTYPE_TCPHDR |
IXGBE_PSRTYPE_UDPHDR |
IXGBE_PSRTYPE_IPV4HDR |
- IXGBE_PSRTYPE_IPV6HDR;
+ IXGBE_PSRTYPE_IPV6HDR |
+ IXGBE_PSRTYPE_L2HDR;
IXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(0), psrtype);
}
} else {
diff --git a/drivers/net/ixgbe/ixgbe_type.h b/drivers/net/ixgbe/ixgbe_type.h
index e49e8af..9fd79a0 100644
--- a/drivers/net/ixgbe/ixgbe_type.h
+++ b/drivers/net/ixgbe/ixgbe_type.h
@@ -1604,6 +1604,7 @@
#define IXGBE_PSRTYPE_UDPHDR 0x00000020
#define IXGBE_PSRTYPE_IPV4HDR 0x00000100
#define IXGBE_PSRTYPE_IPV6HDR 0x00000200
+#define IXGBE_PSRTYPE_L2HDR 0x00001000
/* SRRCTL bit definitions */
#define IXGBE_SRRCTL_BSIZEPKT_SHIFT 10 /* so many KBs */
^ permalink raw reply related [flat|nested] 10+ messages in thread* [net-next-2.6 PATCH 4/5] ixgbe: fix failing to log fan failures
2009-05-07 20:38 [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL Jeff Kirsher
2009-05-07 20:39 ` [net-next-2.6 PATCH 2/5] ixgbe: set queue0 for srrctl configuration correctly for DCB Jeff Kirsher
2009-05-07 20:39 ` [net-next-2.6 PATCH 3/5] ixgbe: Enable L2 header split in 82599 Jeff Kirsher
@ 2009-05-07 20:39 ` Jeff Kirsher
2009-05-07 21:56 ` David Miller
2009-05-07 20:40 ` [net-next-2.6 PATCH 5/5] ixgbe: Typecase '1' for 64 bit shift Jeff Kirsher
2009-05-07 21:55 ` [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL David Miller
4 siblings, 1 reply; 10+ messages in thread
From: Jeff Kirsher @ 2009-05-07 20:39 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Don Skidmore, Peter P Waskiewicz Jr, Jeff Kirsher
From: Don Skidmore <donald.c.skidmore@intel.com>
We weren't logging the 82598AT fan failure if it occurred before (ixgbe_open)
as we hadn't sent up to catch the interrupt that event caused.
This patch checks for this failure in:
ixgbe_probe - So we can log the failure asap. We check right after we
set up the adapter->flags, which is when we know that we have a fan.
ixgbe_up_complete - To catch failures that may have happened between probe
and when we set up the interrupt that would normally detect the fan failure.
To enable all of this we need to initialize the adapter flag with
IXGBE_FLAG_FAN_FAIL_CAPABLE when the NIC contained a fan.
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 28 ++++++++++++++++++++++++++--
1 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 01d8b6b..4a316e9 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2458,6 +2458,17 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter)
ixgbe_irq_enable(adapter);
/*
+ * If this adapter has a fan, check to see if we had a failure
+ * before we enabled the interrupt.
+ */
+ if (adapter->flags & IXGBE_FLAG_FAN_FAIL_CAPABLE) {
+ u32 esdp = IXGBE_READ_REG(hw, IXGBE_ESDP);
+ if (esdp & IXGBE_ESDP_SDP1)
+ DPRINTK(DRV, CRIT,
+ "Fan has stopped, replace the adapter\n");
+ }
+
+ /*
* For hot-pluggable SFP+ devices, a new SFP+ module may have
* arrived before interrupts were enabled. We need to kick off
* the SFP+ module setup first, then try to bring up link.
@@ -3382,9 +3393,11 @@ static int __devinit ixgbe_sw_init(struct ixgbe_adapter *adapter)
adapter->ring_feature[RING_F_RSS].indices = rss;
adapter->flags |= IXGBE_FLAG_RSS_ENABLED;
adapter->ring_feature[RING_F_DCB].indices = IXGBE_MAX_DCB_INDICES;
- if (hw->mac.type == ixgbe_mac_82598EB)
+ if (hw->mac.type == ixgbe_mac_82598EB) {
+ if (hw->device_id == IXGBE_DEV_ID_82598AT)
+ adapter->flags |= IXGBE_FLAG_FAN_FAIL_CAPABLE;
adapter->max_msix_q_vectors = MAX_MSIX_Q_VECTORS_82598;
- else if (hw->mac.type == ixgbe_mac_82599EB) {
+ } else if (hw->mac.type == ixgbe_mac_82599EB) {
adapter->max_msix_q_vectors = MAX_MSIX_Q_VECTORS_82599;
adapter->flags |= IXGBE_FLAG_RSC_CAPABLE;
adapter->flags |= IXGBE_FLAG_RSC_ENABLED;
@@ -4915,6 +4928,17 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
if (err)
goto err_sw_init;
+ /*
+ * If there is a fan on this device and it has failed log the
+ * failure.
+ */
+ if (adapter->flags & IXGBE_FLAG_FAN_FAIL_CAPABLE) {
+ u32 esdp = IXGBE_READ_REG(hw, IXGBE_ESDP);
+ if (esdp & IXGBE_ESDP_SDP1)
+ DPRINTK(PROBE, CRIT,
+ "Fan has stopped, replace the adapter\n");
+ }
+
/* reset_hw fills in the perm_addr as well */
err = hw->mac.ops.reset_hw(hw);
if (err == IXGBE_ERR_SFP_NOT_SUPPORTED) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [net-next-2.6 PATCH 4/5] ixgbe: fix failing to log fan failures
2009-05-07 20:39 ` [net-next-2.6 PATCH 4/5] ixgbe: fix failing to log fan failures Jeff Kirsher
@ 2009-05-07 21:56 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2009-05-07 21:56 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, donald.c.skidmore, peter.p.waskiewicz.jr
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 07 May 2009 13:39:54 -0700
> We weren't logging the 82598AT fan failure if it occurred before (ixgbe_open)
> as we hadn't sent up to catch the interrupt that event caused.
>
> This patch checks for this failure in:
> ixgbe_probe - So we can log the failure asap. We check right after we
> set up the adapter->flags, which is when we know that we have a fan.
> ixgbe_up_complete - To catch failures that may have happened between probe
> and when we set up the interrupt that would normally detect the fan failure.
>
> To enable all of this we need to initialize the adapter flag with
> IXGBE_FLAG_FAN_FAIL_CAPABLE when the NIC contained a fan.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [net-next-2.6 PATCH 5/5] ixgbe: Typecase '1' for 64 bit shift
2009-05-07 20:38 [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL Jeff Kirsher
` (2 preceding siblings ...)
2009-05-07 20:39 ` [net-next-2.6 PATCH 4/5] ixgbe: fix failing to log fan failures Jeff Kirsher
@ 2009-05-07 20:40 ` Jeff Kirsher
2009-05-07 21:56 ` David Miller
2009-05-07 21:55 ` [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL David Miller
4 siblings, 1 reply; 10+ messages in thread
From: Jeff Kirsher @ 2009-05-07 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Shannon Nelson, Jeff Kirsher
From: Nelson, Shannon <shannon.nelson@intel.com>
Make sure we don't get any sign-extend issues when we shift a 1
into bit 31.
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 4a316e9..efb175b 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1307,7 +1307,7 @@ static inline void map_vector_to_rxq(struct ixgbe_adapter *a, int v_idx,
set_bit(r_idx, q_vector->rxr_idx);
q_vector->rxr_count++;
- a->rx_ring[r_idx].v_idx = 1 << v_idx;
+ a->rx_ring[r_idx].v_idx = (u64)1 << v_idx;
}
static inline void map_vector_to_txq(struct ixgbe_adapter *a, int v_idx,
@@ -1317,7 +1317,7 @@ static inline void map_vector_to_txq(struct ixgbe_adapter *a, int v_idx,
set_bit(t_idx, q_vector->txr_idx);
q_vector->txr_count++;
- a->tx_ring[t_idx].v_idx = 1 << v_idx;
+ a->tx_ring[t_idx].v_idx = (u64)1 << v_idx;
}
/**
@@ -4057,7 +4057,7 @@ static void ixgbe_watchdog(unsigned long data)
int i;
for (i = 0; i < adapter->num_msix_vectors - NON_Q_VECTORS; i++)
- eics |= (1 << i);
+ eics |= ((u64)1 << i);
/* Cause software interrupt to ensure rx rings are cleaned */
switch (hw->mac.type) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL
2009-05-07 20:38 [net-next-2.6 PATCH 1/5] ixgbe: always set header length in SRRCTL Jeff Kirsher
` (3 preceding siblings ...)
2009-05-07 20:40 ` [net-next-2.6 PATCH 5/5] ixgbe: Typecase '1' for 64 bit shift Jeff Kirsher
@ 2009-05-07 21:55 ` David Miller
4 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2009-05-07 21:55 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 07 May 2009 13:38:56 -0700
> As per the documentation for 82599 in order to support hardware RSC the
> header size must be set. This is only currently done for packet split
> mode. This patch sets the header buffer length for all modes.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread