From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, jesse.brandeburg@intel.com
Subject: Re: [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb: don't txhang after link down
Date: Thu, 07 May 2009 14:56:37 -0700 (PDT) [thread overview]
Message-ID: <20090507.145637.154290988.davem@davemloft.net> (raw)
In-Reply-To: <20090507210734.20173.63453.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 07 May 2009 14:07:35 -0700
> after the recent changes to wired drivers to use only
> netif_carrier_off the driver can have outstanding tx work to
> complete that will never complete once link is down. Since the
> intel hardware will hold this tx work forever, the driver
> notices a tx timeout condition internally and might try
> to instigate printk and reset of the part with a
> netif_stop_queue, which doesn't work because link is down.
>
> Don't bother arming to tx hang detection when link is down.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2009-05-07 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 21:07 [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb: don't txhang after link down Jeff Kirsher
2009-05-07 21:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507.145637.154290988.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox