From: Ingo Molnar <mingo@elte.hu>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] remove DMA_nBIT_MASK macro
Date: Thu, 7 May 2009 13:18:46 +0200 [thread overview]
Message-ID: <20090507111846.GI28398@elte.hu> (raw)
In-Reply-To: <4A0272C7.3060409@cn.fujitsu.com>
* Yang Hongyang <yanghy@cn.fujitsu.com> wrote:
> FUJITA Tomonori wrote:
> > We replaced all DMA_nBIT_MASK macros with DMA_BIT_MASK(n) but why do
> > we still keep DMA_nBIT_MASK macros in include/linux/dma-mapping.h?
> >
> > As long as these macros exist, people use them. The current git has
> > two users and linux-next have other users.
> >
> > Is it better to remove DMA_nBIT_MASK macros completely now?
Can you see a way to emit build warnings? If yes then that might be
a better solution instead of breaking in-the-pipeline code. We
missed the upstream window of removing the facilities altogether, we
could certainly do that in the next merge window though.
> CC:ingo
>
> I have no objections,actually I used to remove all these defines in my
> first commit of these patch series,but got suggestions that keep these
> defines one more circle.Maybe it's time to remove these defines now or
> to remove at the end of this circle?
>
> Reviewed-by:yanghy@cn.fujitsu.com
Thanks!
Ingo
next prev parent reply other threads:[~2009-05-07 11:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 5:14 [PATCH] remove DMA_nBIT_MASK macro FUJITA Tomonori
2009-05-07 5:33 ` Yang Hongyang
2009-05-07 11:18 ` Ingo Molnar [this message]
2009-05-07 23:35 ` FUJITA Tomonori
2009-05-08 8:00 ` [PATCH 1/1] DMA: mark DMA_nBITS_MASK as deprecated Jiri Slaby
2009-05-09 23:55 ` FUJITA Tomonori
2009-05-10 7:04 ` [PATCH 1/1] dma-mapping: mark DMA_nBITS_MASK as deprecated fix Jiri Slaby
2009-05-11 2:36 ` FUJITA Tomonori
2009-05-11 9:21 ` Jiri Slaby
2009-05-11 12:46 ` Ingo Molnar
2009-05-07 5:34 ` [PATCH] remove DMA_nBIT_MASK macro Andrew Morton
2009-05-07 8:29 ` Yang Hongyang
2009-05-07 8:46 ` Jiri Slaby
2009-05-07 8:59 ` Yang Hongyang
2009-05-07 9:03 ` Jiri Slaby
2009-05-07 23:35 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507111846.GI28398@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).