Re: [PATCH]ipv6:use ipv6_addr_type instead of __ipv6_addr_type

[David Miller <davem@davemloft.net>]

From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Fri, 08 May 2009 09:18:11 +0800

> David Miller wrote:
>> From: Yang Hongyang <yanghy@cn.fujitsu.com>
>> Date: Thu, 07 May 2009 15:47:38 +0800
>> 
>>> Although the function of these two functions are the same,we should use the
>>> encapsulation function of __ipv6_addr_type
>>>
>>> Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
>> 
>> Are you sure?  ipv6_addr_type() masks out the upper 16-bits
>> of __ipv6_addr_type()'s return value, which is the scope.
>> 
>> I'm not convinced that is what we want to do here.
> 
> My advice here is that the function which has __ maybe shouldn't be directly used.

You're using vague terms like "advice" and "maybe" and this
only decreases my confidence in your change.

You're also not addressing my questions at all.

Two "_" characters at the beginning of the function's name says
nothing about whether these call sites want the scope bits present in
the return value they receive.

This seems like a completely pointless and mindless change,
and in fact might introduce bugs.

There is no way I'm applying this.  You can't even explain if the
patch is correct or not.  In fact, I doubt you even know.