From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6] Network Drop Monitor: Fix skb_kill_datagram Date: Fri, 08 May 2009 14:57:15 -0700 (PDT) Message-ID: <20090508.145715.83218368.davem@davemloft.net> References: <1241731554.6567.25.camel@Maple> <20090507.145649.169552244.davem@davemloft.net> <20090508004200.GA15970@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: john.dykstra1@gmail.com, netdev@vger.kernel.org To: nhorman@tuxdriver.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:60902 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbZEHV5T (ORCPT ); Fri, 8 May 2009 17:57:19 -0400 In-Reply-To: <20090508004200.GA15970@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: From: Neil Horman Date: Thu, 7 May 2009 20:42:00 -0400 > On Thu, May 07, 2009 at 02:56:49PM -0700, David Miller wrote: >> From: John Dykstra >> Date: Thu, 07 May 2009 21:25:54 +0000 >> >> > Commit ead2ceb0ec9f85cff19c43b5cdb2f8a054484431 ("Network Drop Monitor: >> > Adding kfree_skb_clean for non-drops and modifying end-of-line points >> > for skbs") established new conventions for identifying dropped packets. >> > >> > Align skb_kill_datagram() with these conventions so that packets that >> > get dropped just before the copy to userspace are properly tracked. >> > >> > Signed-off-by: John Dykstra >> >> Neil, ACK? >> > > Yes, I think it looks good, thank you Jonh, Dave! > > Acked-by: Neil Horman Applied, thanks everyone.