From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: fw@strlen.de, bonding-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix panic if initialization fails
Date: Sat, 09 May 2009 13:20:00 -0700 (PDT) [thread overview]
Message-ID: <20090509.132000.242388766.davem@davemloft.net> (raw)
In-Reply-To: <20090508233604.GD4881@psychotron.englab.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Sat, 9 May 2009 01:36:04 +0200
> Sat, May 09, 2009 at 01:30:57AM CEST, fw@strlen.de wrote:
>>Jiri Pirko <jpirko@redhat.com> wrote:
>>> > err:
>>> >- list_for_each_entry(bond, &bond_dev_list, bond_list) {
>>> >- bond_work_cancel_all(bond);
>>> >- destroy_workqueue(bond->wq);
>>> >- }
>>> This looks correct.
>>>
>>> >-
>>> >- bond_destroy_sysfs();
>>> Why this is not here anymore? I think it should be called in this function.
>>
>>Thanks for reviewing.
>>I removed it because, if you hit this error path, sysfs registration
>>failed, so there is no entry to remove.
>
> Yes, you are right.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied, thanks!
prev parent reply other threads:[~2009-05-09 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 21:49 [PATCH] bonding: fix panic if initialization fails Florian Westphal
2009-05-08 22:10 ` Jay Vosburgh
2009-05-08 23:21 ` Jiri Pirko
2009-05-08 23:30 ` Florian Westphal
2009-05-08 23:36 ` Jiri Pirko
2009-05-09 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090509.132000.242388766.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fw@strlen.de \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).