From: Frans Pop <elendil@planet.nl>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Matthias Andree <matthias.andree@gmx.de>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: Strange Application bug, race in MSG_PEEK complaints (was: Bug#513695: fetchmail: race in MSG_PEEK)
Date: Sat, 9 May 2009 20:14:34 +0200 [thread overview]
Message-ID: <200905092014.35642.elendil@planet.nl> (raw)
In-Reply-To: <Pine.LNX.4.64.0905070931590.12068@wrl-59.cs.helsinki.fi>
On Thursday 07 May 2009, Ilpo Järvinen wrote:
> [RFC PATCH] tcp: fix MSG_PEEK race check
>
> Commit 518a09ef11 (tcp: Fix recvmsg MSG_PEEK influence of
> blocking behavior) lets the loop run longer than this check
> did previously expect, so we need to be more careful with
> this check and consider the work we have been doing.
>
> I'm a bit unsure if this improved check can still fail as
> if (!sock_flag(sk, SOCK_URGINLINE)) {
> ++*seq;
> ...
> does not increment copied.
>
> Compile tested.
>
> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@helsinki.fi>
I've been running with the patch for 2 days now and have not seen any more
MSG_PEEK errors, so as far as I'm concerned the patch does fix the issue
(needed the time in order to be confident of that).
So:
Tested-by: Frans Pop <elendil@planet.nl>
Suggest to also add a CC for stable.
Cheers,
FJP
next prev parent reply other threads:[~2009-05-09 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200902262310.12791.elendil@planet.nl>
[not found] ` <200903091749.50818.elendil@planet.nl>
[not found] ` <op.uqjiqsol1e62zd@merlin.emma.line.org>
[not found] ` <200903141900.14498.elendil@planet.nl>
2009-05-06 16:15 ` Strange Application bug, race in MSG_PEEK complaints (was: Bug#513695: fetchmail: race in MSG_PEEK) Matthias Andree
2009-05-06 23:02 ` Matthias Andree
2009-05-07 6:48 ` Ilpo Järvinen
2009-05-07 17:16 ` Frans Pop
2009-05-07 18:48 ` Ilpo Järvinen
2009-05-07 20:43 ` Frans Pop
2009-05-09 18:14 ` Frans Pop [this message]
2009-05-11 6:32 ` [PATCH v2] tcp: fix MSG_PEEK race check Ilpo Järvinen
2009-05-11 12:50 ` Frans Pop
2009-05-11 13:32 ` Ilpo Järvinen
2009-05-11 13:54 ` Frans Pop
2009-05-11 14:57 ` Ilpo Järvinen
2009-05-17 22:31 ` David Miller
2009-05-18 8:02 ` Matthias Andree
2009-05-17 22:41 ` David Miller
2009-05-18 7:24 ` Ilpo Järvinen
2009-05-18 15:34 ` Matthias Andree
2009-05-18 22:04 ` David Miller
2009-05-19 4:33 ` Ilpo Järvinen
2009-05-19 4:40 ` David Miller
2009-05-19 9:05 ` Matthias Andree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905092014.35642.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=matthias.andree@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).