On Mon, 11 May 2009 22:07:23 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> >> > Note that if the locally generated packet is sent to a local ip,
> >> > dev_queue_xmit() calls loopback_xmit() and the xfrm_input() will
> >> > be called with softirqs enabled.
> >> 
> >> dev_queue_xmit always disables BH before calling the device xmit
> >> function.  So how can this happen?
> >> 
> > 
> > Oops, you right. Thanks for the explanation!
> 
> So you didn't actually hit a bug that led you to write that
> patch?
> 
> Please state this explicitly next time, and tell us that you are
> "fixing" something based purely upon code inspection rather than
> hitting a bug yourself.
> 

Well, I hit some bug (occasional hard lockup of the box on ipsec'ed
data transfers), and this seemed as an excellent fit, because I
frequently test it on local->local trafic. Anyways, sorry for bothering.

YP