Re: [PATCH 2/2] r8169: allow true forced mode setting

[Jean Delvare <jdelvare@suse.de>]

Hi François,

Le jeudi 14 mai 2009, Francois Romieu a écrit :
> Due to mostly historic reasons, including a lack of reliability
> of the link handling (especially with the older 8169), the
> current r8169 driver emulates forced mode setting by limiting
> the advertised modes.
> 
> With this change the driver allows real 10/100 forced mode
> settings on the 8169 and 8101/8102.
> 
> Original idea by Vincent Steenhoute. The RTL_GIGA_MAC_VER_03
> tweak was extracted from Realtek's v6.009.00 driver.

If I read the code correctly, Realtek's driver (v6.010.00) only
applies the quirk for RTL8169S and RTL8110S chips (what I have) and
not the original RTL8169. Your code applies the quirk to all 3
chips. Is this on purpose? Or am I missing something?

> (...)
> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_03) {
> +		if ((speed == SPEED_100) && (autoneg != AUTONEG_ENABLE)) {
> +			mdio_write(ioaddr, 0x17, 0x2138);
> +			mdio_write(ioaddr, 0x0e, 0x0260);
> +		} else {
> +			mdio_write(ioaddr, 0x17, 0x2108);
> +			mdio_write(ioaddr, 0x0e, 0x0000);
> +		}
> +	}
> +
>  	return 0;
>  }

Thanks,
-- 
Jean Delvare
Suse L3