From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Robert Olsson <robert@robur.slu.se>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
andrei.popa@i-neo.ro, Robert Olsson <Robert.Olsson@data.slu.se>,
NetDEV list <netdev@vger.kernel.org>
Subject: Re: [oops] with FIB_TRIE
Date: Sat, 16 May 2009 14:24:48 -0700 [thread overview]
Message-ID: <20090516212448.GC6973@linux.vnet.ibm.com> (raw)
In-Reply-To: <18956.37696.186135.21348@robur.slu.se>
On Thu, May 14, 2009 at 11:55:12PM +0200, Robert Olsson wrote:
>
> Stephen Hemminger writes:
>
> > > I recompiled the kernel with FIB_TRIE and no preemption and it doesn't
> > > oops anymore.
>
> Thanks, for testing Andrei. I've had routing tables continusly going up
> and down for 24 hours (with no preemption) without any problem.
>
> > Maybe the rcu_read_lock needs to be rcu_read_lock_bh?
>
> Maybe,
> Need to recap this... at least for myself insert, delete and flush is
> serialised wrt RTNL I guess this is still OK. We oops in lookup but
> we should have preempt_disable as we're in a RCU read section. Also we
> know quagga is constantly running delete...
RCU read-side critical sections are not preempt_disable() if you have
built with CONFIG_PREEMPT_RCU.
Thanx, Paul
next prev parent reply other threads:[~2009-05-16 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 11:24 [oops] with FIB_TRIE Andrei Popa
2009-05-12 15:15 ` Robert Olsson
2009-05-14 11:54 ` Andrei Popa
2009-05-14 20:00 ` Stephen Hemminger
2009-05-14 21:55 ` Robert Olsson
2009-05-16 21:24 ` Paul E. McKenney [this message]
2009-05-17 13:44 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090516212448.GC6973@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Robert.Olsson@data.slu.se \
--cc=andrei.popa@i-neo.ro \
--cc=netdev@vger.kernel.org \
--cc=robert@robur.slu.se \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).