From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netpoll: don't dereference NULL dev from np
Date: Sun, 17 May 2009 20:38:17 -0700 (PDT) [thread overview]
Message-ID: <20090517.203817.250076003.davem@davemloft.net> (raw)
In-Reply-To: <4A07FFB3.70308@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 11 May 2009 14:36:35 +0400
> It looks like the dev in netpoll_poll can be NULL - at lease it's
> checked at the function beginning. Thus the dev->netde_ops dereference
> looks dangerous.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Good catch, probably added by the netdev_ops changes.
Applied, thanks!
prev parent reply other threads:[~2009-05-18 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 10:36 [PATCH] netpoll: don't dereference NULL dev from np Pavel Emelyanov
2009-05-18 3:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090517.203817.250076003.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).