public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: bridge@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] bridge: fix initial packet flood if !STP
Date: Sun, 17 May 2009 21:13:48 -0700 (PDT)	[thread overview]
Message-ID: <20090517.211348.115670295.davem@davemloft.net> (raw)
In-Reply-To: <20090515091158.55090cd0@nehalam>

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 15 May 2009 09:11:58 -0700

> If bridge is configured with no STP and forwarding delay of 0 (which
> is typical for virtualization) then when link starts it will flood all
> packets for the first 20 seconds. 
> 
> This bug was introduced by a combination of earlier changes:
>   * forwarding database uses hold time of zero to indicate 
>     user wants to always flood packets
>   * optimzation of the case of forwarding delay of 0 avoids the initial
>     timer tick
> 
> The fix is to just skip all the topology change detection code if
> kernel STP is not being used.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Also applied, thanks Stephen.

To avoid confusion, I did apply these to net-2.6 since they
are fixes.

Thanks!

  reply	other threads:[~2009-05-18  4:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 16:10 [PATCH 1/2] bridge: relay bridge multicast pkgs if !STP Stephen Hemminger
2009-05-15 16:11 ` [PATCH 2/2] bridge: fix initial packet flood " Stephen Hemminger
2009-05-18  4:13   ` David Miller [this message]
2009-05-18  4:13 ` [PATCH 1/2] bridge: relay bridge multicast pkgs " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090517.211348.115670295.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox