From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: shemminger@vyatta.com, bonding-devel@lists.sf.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix link down handling in 802.3ad mode
Date: Sun, 17 May 2009 21:16:05 -0700 (PDT) [thread overview]
Message-ID: <20090517.211605.119521245.davem@davemloft.net> (raw)
In-Reply-To: <12527.1242416155@death.nxdomain.ibm.com>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 15 May 2009 12:35:55 -0700
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
>>One of the purposes of bonding is to allow for redundant links, and failover
>>correctly if the cable is pulled. If all the members of a bonded device have
>>no carrier present, the bonded device itself needs to report no carrier present
>>to user space so management tools (like routing daemons) can respond.
>>
>>Bonding in 802.3ad mode does not work correctly for this because it incorrectly
>>chooses a link that is down as a possible aggregator.
>>
>>Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Looks good. I tested this after putting some printks in the agg
> selection logic, and I don't see any undesirable side effects.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks everyone.
prev parent reply other threads:[~2009-05-18 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 18:44 [PATCH] bonding: fix link down handling in 802.3ad mode Stephen Hemminger
2009-05-15 19:35 ` Jay Vosburgh
2009-05-18 4:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090517.211605.119521245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sf.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox