From: Rusty Russell <rusty@rustcorp.com.au>
To: Avi Kivity <avi@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
dlaor@redhat.com, netdev@vger.kernel.org,
Dor Laor <dor@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC)
Date: Sun, 17 May 2009 23:46:12 +0930 [thread overview]
Message-ID: <200905172346.14498.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A0FAE35.3040608@redhat.com>
On Sun, 17 May 2009 03:57:01 pm Avi Kivity wrote:
> Rusty Russell wrote:
> > +static void adjust_threshold(struct vring_virtqueue *vq,
> > + unsigned int out, unsigned int in)
> > +{
> > + /* There are really two species of virtqueue, and it matters here.
> > + * If there are no output parts, it's a "normally full" receive queue,
> > + * otherwise it's a "normally empty" send queue. */
>
> This comment is true for networking, but not for block. ++overkill with
> a ->adjust_threshold op.
No, it's true for block. It has output parts, so we should reduce threshold
when it's full. Network recvq is an example which should reduce threshold
when it's empty.
->adjust_threshold is better as an arg to vring_new_virtqueue, but it's still
not clear what the answer would be.
Rusty.
next prev parent reply other threads:[~2009-05-17 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1229620222-22216-1-git-send-email-markmc@redhat.com>
[not found] ` <1229620222-22216-2-git-send-email-markmc@redhat.com>
[not found] ` <1229620222-22216-3-git-send-email-markmc@redhat.com>
2009-04-21 12:59 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2009-04-27 7:43 ` Dor Laor
2009-05-04 2:19 ` Rusty Russell
2009-05-11 17:10 ` Mark McLoughlin
2009-05-11 17:11 ` [PATCH 1/3] virtio: teach virtio_has_feature() about transport features Mark McLoughlin
2009-05-11 17:11 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2009-05-11 17:11 ` [PATCH 3/3] lguest: add support for indirect ring entries Mark McLoughlin
2009-05-12 14:23 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Rusty Russell
2009-05-17 2:04 ` Rusty Russell
2009-05-17 6:27 ` Avi Kivity
2009-05-17 14:16 ` Rusty Russell [this message]
2009-05-17 15:05 ` Avi Kivity
2009-05-19 8:15 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905172346.14498.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=dor@redhat.com \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).