From: David Miller <davem@davemloft.net>
To: sergk@sergk.org.ua
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when enabling ip_forward
Date: Mon, 18 May 2009 15:35:31 -0700 (PDT) [thread overview]
Message-ID: <20090518.153531.126023429.davem@davemloft.net> (raw)
In-Reply-To: <20090519010147.772f0bff@vingilot.sergknet>
From: Sergey Kononenko <sergk@sergk.org.ua>
Date: Tue, 19 May 2009 01:01:47 +0300
> I have system with two Intel 82575EB 1Gb/s NICs and two Intel 82598EB
> 10Gb/s NICs (motherboard Supermicro X7DWU). I'm using kernel 2.6.29.3
> with compiled in drivers for both types of NICs with LRO enabled:
> CONFIG_INET_LRO=y
> CONFIG_IGB=y
> CONFIG_IGB_LRO=y
> CONFIG_IGB_DCA=y
> CONFIG_IXGBE=y
> CONFIG_IXGBE_DCA=y
>
> After boot process is completed according to ethtool LRO is disabled on igb
> and enabled on ixgbe. After I'm trying to turn on forwarding by
> sysctl -w net.ipv4.ip_forward=1 I get following in dmesg:
The problem is that the IGB driver in 2.6.29.3 is buggy, it supports
LRO but does not hook up a ->set_flags ethtool_ops function. That's
why this warning triggers.
It should be pretty easy to fix, since there is a generic
implementation provided in net/core/ethtool.c, and IXGB properly
hooks up this method as well.
next prev parent reply other threads:[~2009-05-18 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 22:01 WARNING at dev_disable_lro when enabling ip_forward Sergey Kononenko
2009-05-18 22:35 ` David Miller [this message]
2009-05-18 22:57 ` [IGB 2.6.29.3 bug] " Stephen Hemminger
2009-05-18 23:00 ` David Miller
2009-05-18 23:07 ` Jeff Kirsher
2009-05-18 23:08 ` Stephen Hemminger
2009-05-18 23:41 ` David Miller
2009-05-19 20:46 ` Sergey Kononenko
2009-05-19 22:06 ` Jeff Kirsher
2009-05-19 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518.153531.126023429.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sergk@sergk.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).