From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au,
shemminger@vyatta.com, greearb@candelatech.com, kaber@trash.net
Subject: Re: [PATCH 0/7] IPv4/IPv6 unregistration deadlock fixes
Date: Mon, 18 May 2009 22:16:37 -0700 (PDT) [thread overview]
Message-ID: <20090518.221637.98842683.davem@davemloft.net> (raw)
In-Reply-To: <m13ab8s8cr.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 13 May 2009 19:53:40 -0700
> A while ago it was noticed that unregistering network devices could cause
> deadlocks if virtual files that take the rtnl_lock were accessed at the
> wrong time.
>
> After looking at the different possibilities the only way to solve it
> cleanly without some kind of busy loop appears to be reducing the scope
> of the rtnl lock.
>
> I have not tackled the hard fix yet but I have tested our current work
> around and it does not succeed in restarting the system call and
> instead leaks -ERESTARNOSYS to userspace, because we do not have a
> signal pending.
>
> Further the current work around misses several interesting places
> in the network stack where the deadlock can occur.
>
> I have addressed the problems by making a common helper function
> and patching all of the places I could find that had this problem.
I've added these changes to net-next-2.6, thanks.
I really can't justify sticking this into net-2.6, especially
this late in the series, sorry.
next prev parent reply other threads:[~2009-05-19 5:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 2:53 [PATCH 0/7] IPv4/IPv6 unregistration deadlock fixes Eric W. Biederman
2009-05-14 2:55 ` [PATCH] syscall: Implement a convinience function restart_syscall Eric W. Biederman
2009-05-14 2:57 ` [PATCH 2/7] net-sysfs: Use rtnl_trylock in sysfs methods Eric W. Biederman
2009-05-14 2:58 ` [PATCH 3/7] net: FIX ipv6_forward sysctl restart Eric W. Biederman
2009-05-14 2:59 ` [PATCH 4/7] net: Fix devinet_sysctl_forward Eric W. Biederman
2009-05-14 3:00 ` [PATCH 5/7] net: Fix bridgeing sysfs handling of rtnl_lock Eric W. Biederman
2009-05-14 3:01 ` [PATCH 6/7] net: Fix ipoib rtnl_lock sysfs deadlock Eric W. Biederman
2009-05-14 3:02 ` [PATCH 7/7] net: FIX bonding sysfs rtnl_lock deadlock Eric W. Biederman
2009-05-14 3:40 ` [PATCH 0/7] IPv4/IPv6 unregistration deadlock fixes David Miller
2009-05-14 6:44 ` [PATCH 1/7] syscall: Implement a convinience function restart_syscall Eric W. Biederman
2009-05-19 5:16 ` David Miller [this message]
2009-05-19 8:07 ` [PATCH 0/7] IPv4/IPv6 unregistration deadlock fixes Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518.221637.98842683.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).