From: David Miller <davem@davemloft.net>
To: brice@myri.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool
Date: Tue, 19 May 2009 15:26:08 -0700 (PDT) [thread overview]
Message-ID: <20090519.152608.149436309.davem@davemloft.net> (raw)
In-Reply-To: <4A131364.5050402@myri.com>
From: Brice Goglin <brice@myri.com>
Date: Tue, 19 May 2009 22:15:32 +0200
> Allow myri10ge LRO to be enabled/disabled via ethtool
> (and by the stack for packet forwarding).
>
> Signed-off-by: Brice Goglin <brice@myri.com>
So I applied these two patches for now to net-next-2.6
but in the long term I think it's probably better to convert
this driver to GRO as we're trying to get rid of LRO and
GRO handles forwarding and all of that stuff transparently.
And I also still want the myri10ge_lro module option removed
regardless of whether you do a GRO conversion or not.
If LRO/GRO causes a performance regression in some situation,
we should fix it instead of papering over this junk with
module options.
Thanks.
prev parent reply other threads:[~2009-05-19 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 20:15 [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool Brice Goglin
2009-05-19 21:28 ` David Miller
2009-05-19 22:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519.152608.149436309.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).