From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netdev@vger.kernel.org, samuel@sortiz.org, johannes@sipsolutions.net
Subject: Re: [PATCH] net: use NLMSG_DEFAULT_SIZE in nlmsg_new() allocations
Date: Tue, 19 May 2009 15:28:07 -0700 (PDT) [thread overview]
Message-ID: <20090519.152807.141633274.davem@davemloft.net> (raw)
In-Reply-To: <20090519155820.27716.47419.stgit@Decadence>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 19 May 2009 17:58:20 +0200
> nlmsg_new() adds the size of the netlink header to the value
> that has been passed as parameter. If NLMSG_GOODSIZE is selected,
> we request an allocation of one memory page plus the size of the
> header. Instead, NLMSG_DEFAULT_SIZE should be used since it
> already substracts the size of the Netlink header.
>
> I have the impression that the similar naming in both constant
> is error prone when using it with nlmsg_new(). This is already
> documented in include/net/netlink.h
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Looks good, applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-05-19 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 15:58 [PATCH] net: use NLMSG_DEFAULT_SIZE in nlmsg_new() allocations Pablo Neira Ayuso
2009-05-19 22:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519.152807.141633274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).