* [PATCH] Allow selecting mv643xx_eth on Pegasos again
@ 2009-05-18 17:37 Gabriel Paubert
2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
0 siblings, 1 reply; 10+ messages in thread
From: Gabriel Paubert @ 2009-05-18 17:37 UTC (permalink / raw)
To: Lennert Buytenhek
Cc: David Miller, tbm, pacman, netdev, Matt Sealey,
Benjamin Herrenschmidt, LinuxPPC
Since PPC_MUTIPLATFORM was removed, it was impossible to select the
driver for mv643xx_eth on the Pegasos. Fix by allowing to select
the driver on CHRP platforms; Pegasos is a CHRP platform and the driver
will not work without arch/powerpc/platforms/chrp/pegasos_eth.
Signed-off-by: Gabriel Paubert <paubert@iram.es>
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 214a92d..6fc0ff4 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
config MV643XX_ETH
tristate "Marvell Discovery (643XX) and Orion ethernet support"
- depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION
+ depends on MV64X60 || PPC_CHRP || PLAT_ORION
select INET_LRO
select PHYLIB
help
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 17:37 [PATCH] Allow selecting mv643xx_eth on Pegasos again Gabriel Paubert
@ 2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
2009-05-18 18:47 ` Gabriel Paubert
0 siblings, 1 reply; 10+ messages in thread
From: Medve Emilian-EMMEDVE1 @ 2009-05-18 17:48 UTC (permalink / raw)
To: Gabriel Paubert, Lennert Buytenhek
Cc: tbm, LinuxPPC, pacman, netdev, David Miller
> -----Original Message-----
> From: linuxppc-dev-bounces+emilian.medve=freescale.com@ozlabs.org
[mailto:linuxppc-dev-
> bounces+emilian.medve=freescale.com@ozlabs.org] On Behalf Of Gabriel
Paubert
> Sent: Monday, May 18, 2009 12:38 PM
> To: Lennert Buytenhek
> Cc: tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
netdev@vger.kernel.org; David Miller
> Subject: [PATCH] Allow selecting mv643xx_eth on Pegasos again
>
> Since PPC_MUTIPLATFORM was removed, it was impossible to select the
> driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> the driver on CHRP platforms; Pegasos is a CHRP platform and the
driver
> will not work without arch/powerpc/platforms/chrp/pegasos_eth.
>
> Signed-off-by: Gabriel Paubert <paubert@iram.es>
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 214a92d..6fc0ff4 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
>
> config MV643XX_ETH
> tristate "Marvell Discovery (643XX) and Orion ethernet support"
> - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
PLAT_ORION
> + depends on MV64X60 || PPC_CHRP || PLAT_ORION
> select INET_LRO
> select PHYLIB
> help
This got fixed here:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8
Cheers,
Emil.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
@ 2009-05-18 18:47 ` Gabriel Paubert
2009-05-18 20:15 ` Medve Emilian-EMMEDVE1
0 siblings, 1 reply; 10+ messages in thread
From: Gabriel Paubert @ 2009-05-18 18:47 UTC (permalink / raw)
To: Medve Emilian-EMMEDVE1
Cc: Lennert Buytenhek, tbm, LinuxPPC, pacman, netdev, David Miller
On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1 wrote:
> > -----Original Message-----
> > From: linuxppc-dev-bounces+emilian.medve=freescale.com@ozlabs.org
> [mailto:linuxppc-dev-
> > bounces+emilian.medve=freescale.com@ozlabs.org] On Behalf Of Gabriel
> Paubert
> > Sent: Monday, May 18, 2009 12:38 PM
> > To: Lennert Buytenhek
> > Cc: tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
> netdev@vger.kernel.org; David Miller
> > Subject: [PATCH] Allow selecting mv643xx_eth on Pegasos again
> >
> > Since PPC_MUTIPLATFORM was removed, it was impossible to select the
> > driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> > the driver on CHRP platforms; Pegasos is a CHRP platform and the
> driver
> > will not work without arch/powerpc/platforms/chrp/pegasos_eth.
> >
> > Signed-off-by: Gabriel Paubert <paubert@iram.es>
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 214a92d..6fc0ff4 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
> >
> > config MV643XX_ETH
> > tristate "Marvell Discovery (643XX) and Orion ethernet support"
> > - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
> PLAT_ORION
> > + depends on MV64X60 || PPC_CHRP || PLAT_ORION
> > select INET_LRO
> > select PHYLIB
> > help
>
> This got fixed here:
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
> tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8
Ok, I was not aware of it, but the fact is that MV64360 no more exists
and the only non MV64X60 platform that may need it is the Pegasos (to my
knowledge) and it relies on some platform specific code enabled
by PPC_CHRP.
Regards,
Gabriel
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 18:47 ` Gabriel Paubert
@ 2009-05-18 20:15 ` Medve Emilian-EMMEDVE1
2009-05-18 22:18 ` Gabriel Paubert
0 siblings, 1 reply; 10+ messages in thread
From: Medve Emilian-EMMEDVE1 @ 2009-05-18 20:15 UTC (permalink / raw)
To: Gabriel Paubert
Cc: Lennert Buytenhek, tbm, LinuxPPC, pacman, netdev, David Miller
Hello Gabriel,
> -----Original Message-----
> From: Gabriel Paubert [mailto:paubert@iram.es]
> Sent: Monday, May 18, 2009 1:48 PM
> To: Medve Emilian-EMMEDVE1
> Cc: Lennert Buytenhek; tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
netdev@vger.kernel.org; David
> Miller
> Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
>
> On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1
wrote:
> > > -----Original Message-----
> > > From: linuxppc-dev-bounces+emilian.medve=freescale.com@ozlabs.org
> > [mailto:linuxppc-dev-
> > > bounces+emilian.medve=freescale.com@ozlabs.org] On Behalf Of
Gabriel
> > Paubert
> > > Sent: Monday, May 18, 2009 12:38 PM
> > > To: Lennert Buytenhek
> > > Cc: tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
> > netdev@vger.kernel.org; David Miller
> > > Subject: [PATCH] Allow selecting mv643xx_eth on Pegasos again
> > >
> > > Since PPC_MUTIPLATFORM was removed, it was impossible to select
the
> > > driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> > > the driver on CHRP platforms; Pegasos is a CHRP platform and the
> > driver
> > > will not work without arch/powerpc/platforms/chrp/pegasos_eth.
> > >
> > > Signed-off-by: Gabriel Paubert <paubert@iram.es>
> > >
> > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > > index 214a92d..6fc0ff4 100644
> > > --- a/drivers/net/Kconfig
> > > +++ b/drivers/net/Kconfig
> > > @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
> > >
> > > config MV643XX_ETH
> > > tristate "Marvell Discovery (643XX) and Orion ethernet support"
> > > - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
> > PLAT_ORION
> > > + depends on MV64X60 || PPC_CHRP || PLAT_ORION
> > > select INET_LRO
> > > select PHYLIB
> > > help
> >
> > This got fixed here:
> >
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
> > tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8
>
> Ok, I was not aware of it, but the fact is that MV64360 no more exists
> and the only non MV64X60 platform that may need it is the Pegasos (to
my
> knowledge) and it relies on some platform specific code enabled
> by PPC_CHRP.
You're correct. MV64360 seems to be stale. Do you want to re-spin your
patch to get rid of it?
(I wouldn't create a dependency between MV643XX_ETH and PPC_CHRP.)
Cheers,
Emil.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 20:15 ` Medve Emilian-EMMEDVE1
@ 2009-05-18 22:18 ` Gabriel Paubert
2009-05-18 22:53 ` Medve Emilian-EMMEDVE1
0 siblings, 1 reply; 10+ messages in thread
From: Gabriel Paubert @ 2009-05-18 22:18 UTC (permalink / raw)
To: Medve Emilian-EMMEDVE1
Cc: Lennert Buytenhek, tbm, LinuxPPC, pacman, netdev, David Miller
Hello Medve
On Mon, May 18, 2009 at 01:15:12PM -0700, Medve Emilian-EMMEDVE1 wrote:
>
> You're correct. MV64360 seems to be stale. Do you want to re-spin your
> patch to get rid of it?
No problem, bu should I respin in from the current official git
or on top of yours?
>
> (I wouldn't create a dependency between MV643XX_ETH and PPC_CHRP.)
Fine with me.
Regards,
Gabriel
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 22:18 ` Gabriel Paubert
@ 2009-05-18 22:53 ` Medve Emilian-EMMEDVE1
2009-05-18 23:21 ` [PATCH v2] " Gabriel Paubert
0 siblings, 1 reply; 10+ messages in thread
From: Medve Emilian-EMMEDVE1 @ 2009-05-18 22:53 UTC (permalink / raw)
To: Gabriel Paubert
Cc: Lennert Buytenhek, tbm, LinuxPPC, pacman, netdev, David Miller
Hello Gabriel,
> -----Original Message-----
> From: Gabriel Paubert [mailto:paubert@iram.es]
> Sent: Monday, May 18, 2009 5:19 PM
> To: Medve Emilian-EMMEDVE1
> Cc: Lennert Buytenhek; tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
netdev@vger.kernel.org; David
> Miller
> Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
>
> Hello Medve
>
> On Mon, May 18, 2009 at 01:15:12PM -0700, Medve Emilian-EMMEDVE1
wrote:
> >
> > You're correct. MV64360 seems to be stale. Do you want to re-spin
your
> > patch to get rid of it?
>
>
> No problem, bu should I respin in from the current official git
> or on top of yours?
Top of the tree should be good.
Cheers,
Emil.
> > (I wouldn't create a dependency between MV643XX_ETH and PPC_CHRP.)
>
> Fine with me.
>
> Regards,
> Gabriel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 22:53 ` Medve Emilian-EMMEDVE1
@ 2009-05-18 23:21 ` Gabriel Paubert
2009-05-19 2:35 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Gabriel Paubert @ 2009-05-18 23:21 UTC (permalink / raw)
To: Medve Emilian-EMMEDVE1
Cc: Lennert Buytenhek, tbm, LinuxPPC, pacman, netdev, David Miller
Since PPC_MUTIPLATFORM was removed, it was impossible to select the
driver for mv643xx_eth on the Pegasos. Fix it and take the opportunity
to remove the stale MV64360 config option.
Signed-off-by: Gabriel Paubert <paubert@iram.es>
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 214a92d..aff4f8c 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
config MV643XX_ETH
tristate "Marvell Discovery (643XX) and Orion ethernet support"
- depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION
+ depends on MV64X60 || PPC32 || PLAT_ORION
select INET_LRO
select PHYLIB
help
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] Allow selecting mv643xx_eth on Pegasos again
2009-05-18 23:21 ` [PATCH v2] " Gabriel Paubert
@ 2009-05-19 2:35 ` David Miller
2009-05-19 7:40 ` [PATCH v3] Remove obsolete MV64360 config option Gabriel Paubert
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2009-05-19 2:35 UTC (permalink / raw)
To: paubert; +Cc: Emilian.Medve, buytenh, tbm, linuxppc-dev, pacman, netdev
From: Gabriel Paubert <paubert@iram.es>
Date: Tue, 19 May 2009 01:21:13 +0200
> Since PPC_MUTIPLATFORM was removed, it was impossible to select the
> driver for mv643xx_eth on the Pegasos. Fix it and take the opportunity
> to remove the stale MV64360 config option.
>
> Signed-off-by: Gabriel Paubert <paubert@iram.es>
This patch doesn't even apply to net-next-2.6, please send me
changes relative to that.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] Remove obsolete MV64360 config option
2009-05-19 2:35 ` David Miller
@ 2009-05-19 7:40 ` Gabriel Paubert
2009-05-26 5:46 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Gabriel Paubert @ 2009-05-19 7:40 UTC (permalink / raw)
To: David Miller; +Cc: Emilian.Medve, buytenh, tbm, pacman, netdev
Signed-off-by: Gabriel Paubert <paubert@iram.es>
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index a10e054..570345d 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2350,7 +2350,7 @@ config UGETH_TX_ON_DEMAND
config MV643XX_ETH
tristate "Marvell Discovery (643XX) and Orion ethernet support"
- depends on MV64360 || MV64X60 || PPC32 || PLAT_ORION
+ depends on MV64X60 || PPC32 || PLAT_ORION
select INET_LRO
select PHYLIB
help
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-05-26 5:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-18 17:37 [PATCH] Allow selecting mv643xx_eth on Pegasos again Gabriel Paubert
2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
2009-05-18 18:47 ` Gabriel Paubert
2009-05-18 20:15 ` Medve Emilian-EMMEDVE1
2009-05-18 22:18 ` Gabriel Paubert
2009-05-18 22:53 ` Medve Emilian-EMMEDVE1
2009-05-18 23:21 ` [PATCH v2] " Gabriel Paubert
2009-05-19 2:35 ` David Miller
2009-05-19 7:40 ` [PATCH v3] Remove obsolete MV64360 config option Gabriel Paubert
2009-05-26 5:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).