From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [Bug 13339] New: rtable leak in ipv4/route.c Date: Tue, 19 May 2009 19:05:51 -0400 Message-ID: <20090519230551.GA20555@hmsreliant.think-freely.org> References: <20090519162048.GB28034@hmsreliant.think-freely.org> <4A12FEDA.7040806@cosmosbay.com> <20090519192450.GF28034@hmsreliant.think-freely.org> <20090519.150517.62361946.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dada1@cosmosbay.com, jarkao2@gmail.com, lav@yar.ru, shemminger@linux-foundation.org, netdev@vger.kernel.org To: David Miller Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:36939 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754886AbZESXGJ (ORCPT ); Tue, 19 May 2009 19:06:09 -0400 Content-Disposition: inline In-Reply-To: <20090519.150517.62361946.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, May 19, 2009 at 03:05:17PM -0700, David Miller wrote: > From: Neil Horman > Date: Tue, 19 May 2009 15:24:50 -0400 > > >> Moving whole group in front would defeat the purpose of move, actually, > >> since rank in chain is used to decay the timeout in garbage collector. > >> (search for tmo >>= 1; ) > >> > > Argh, so the list is implicitly ordered by expiration time. That > > really defeats the entire purpose of doing grouping in the ilst at > > all. If thats the case, then I agree, its probably better to to > > take the additional visitation hit in in check_expire above than to > > try and preserve ordering. > > Yes, this seems best. > > I was worried that somehow the ordering also influences lookups, > because the TOS bits don't go into the hash so I worried that it would > be important that explicit TOS values appear before wildcard ones. > But it doesn't appear that this is an issue, we don't have wildcard > TOSs in the rtable entries, they are always explicit. > > So I would like to see an explicit final patch from Eric so we can get > this fixed now. > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Agreed, thanks once again for educating me Eric! Neil