netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: "David Miller" <davem@davemloft.net>, 吉藤英明 <yoshfuji@linux-ipv6.org>
Cc: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>,
	netdev@vger.kernel.org
Subject: [PATCH] ipv6: route templates missing protocol value
Date: Wed, 20 May 2009 12:30:38 -0700	[thread overview]
Message-ID: <20090520123038.5bb2a2da@nehalam> (raw)
In-Reply-To: <4A11B52D.8030105@6wind.com>

The IPV6 routing templates are missing the protocol value so
when they are used, the routes have the protocol RTPROT_UNSPEC (0).
This confuses Zebra routing protocol daemon that makes kernel routes
a special case. This was first noticed by Jean-Mickael Guerin
who wrote this patch.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 net/ipv6/route.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

--- a/net/ipv6/route.c	2009-05-15 13:32:34.138684428 -0700
+++ b/net/ipv6/route.c	2009-05-20 12:26:19.435815459 -0700
@@ -137,6 +137,7 @@ static struct rt6_info ip6_null_entry_te
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };
@@ -159,6 +160,7 @@ static struct rt6_info ip6_prohibit_entr
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };
@@ -176,6 +178,7 @@ static struct rt6_info ip6_blk_hole_entr
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };

       reply	other threads:[~2009-05-20 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A0EA766.9090008@6wind.com>
     [not found] ` <4A11B52D.8030105@6wind.com>
2009-05-20 19:30   ` Stephen Hemminger [this message]
2009-05-20 19:42     ` [PATCH] ipv6: route templates missing protocol value David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090520123038.5bb2a2da@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=jean-mickael.guerin@6wind.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).