* [PATCH] ipv6: route templates missing protocol value
[not found] ` <4A11B52D.8030105@6wind.com>
@ 2009-05-20 19:30 ` Stephen Hemminger
2009-05-20 19:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-05-20 19:30 UTC (permalink / raw)
To: David Miller, 吉藤英明
Cc: Jean-Mickael Guerin, netdev
The IPV6 routing templates are missing the protocol value so
when they are used, the routes have the protocol RTPROT_UNSPEC (0).
This confuses Zebra routing protocol daemon that makes kernel routes
a special case. This was first noticed by Jean-Mickael Guerin
who wrote this patch.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
net/ipv6/route.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
--- a/net/ipv6/route.c 2009-05-15 13:32:34.138684428 -0700
+++ b/net/ipv6/route.c 2009-05-20 12:26:19.435815459 -0700
@@ -137,6 +137,7 @@ static struct rt6_info ip6_null_entry_te
}
},
.rt6i_flags = (RTF_REJECT | RTF_NONEXTHOP),
+ .rt6i_protocol = RTPROT_KERNEL,
.rt6i_metric = ~(u32) 0,
.rt6i_ref = ATOMIC_INIT(1),
};
@@ -159,6 +160,7 @@ static struct rt6_info ip6_prohibit_entr
}
},
.rt6i_flags = (RTF_REJECT | RTF_NONEXTHOP),
+ .rt6i_protocol = RTPROT_KERNEL,
.rt6i_metric = ~(u32) 0,
.rt6i_ref = ATOMIC_INIT(1),
};
@@ -176,6 +178,7 @@ static struct rt6_info ip6_blk_hole_entr
}
},
.rt6i_flags = (RTF_REJECT | RTF_NONEXTHOP),
+ .rt6i_protocol = RTPROT_KERNEL,
.rt6i_metric = ~(u32) 0,
.rt6i_ref = ATOMIC_INIT(1),
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: route templates missing protocol value
2009-05-20 19:30 ` [PATCH] ipv6: route templates missing protocol value Stephen Hemminger
@ 2009-05-20 19:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-20 19:42 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, jean-mickael.guerin, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 20 May 2009 12:30:38 -0700
> The IPV6 routing templates are missing the protocol value so
> when they are used, the routes have the protocol RTPROT_UNSPEC (0).
> This confuses Zebra routing protocol daemon that makes kernel routes
> a special case. This was first noticed by Jean-Mickael Guerin
> who wrote this patch.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
What's wrong with Jean-Mickael Guerin's patch? He provided
a signoff and everything.
Are you Napoleon? :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-20 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4A0EA766.9090008@6wind.com>
[not found] ` <4A11B52D.8030105@6wind.com>
2009-05-20 19:30 ` [PATCH] ipv6: route templates missing protocol value Stephen Hemminger
2009-05-20 19:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).