netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stefanr@s5r6.in-berlin.de
Cc: netdev@vger.kernel.org, fenlason@redhat.com,
	linux1394-devel@lists.sourceforge.net,
	linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name
Date: Thu, 21 May 2009 13:33:04 -0700 (PDT)	[thread overview]
Message-ID: <20090521.133304.10307675.davem@davemloft.net> (raw)
In-Reply-To: <4A15B5FE.3070207@s5r6.in-berlin.de>

From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Thu, 21 May 2009 22:13:50 +0200

> But I mildly disagree with the notion that the kernel can't start off
> with more qualification of the names than merely ensuring their
> uniqueness.  Or the other way around: Even an entirely meaningless
> prefix would be better than "eth..", or no prefix if that's possible,
> because eth suspiciously sounds like Ethernet with which the misnamed
> RFC 2734 driver eth1394 has very little to do.

Even the driver source file is named "ethXXX"!  All of the macros
in the driver are named ETH*.  The eth1394hdr looks eerily similar
to a real ethernet header except that it lacks a source MAC
address.  It's addressing information plus a 16-bit (wow, why that
size huh?) protocol field.  A lot like ethernet.

At the very least, it's related and similar.  So there is really
nothing inappropriate about eth* naming.

> However, how mild my disagreement is should be apparent from the fact
> that I didn't bother to suggest changing it before now, in 2009. :-)

You have more to lose by changing this now (breaking existing systems,
and yes I did see the hack workaround you posted) instead of fixing
userspace to make whatever indications you deem appropriate.

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 

  reply	other threads:[~2009-05-21 20:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 13:29 [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name Stefan Richter
2009-05-21 13:48 ` Jiri Pirko
2009-05-21 14:31   ` Stefan Richter
2009-05-21 16:43     ` Kay Sievers
     [not found]     ` <alpine.DEB.2.01.0905232309400.7424@bogon>
2009-05-24  9:47       ` Stefan Richter
2009-05-25  8:33         ` Matthias Schwarzott
2009-05-25 10:43           ` Stefan Richter
2009-05-25 10:57           ` Kay Sievers
2009-05-21 19:34 ` David Miller
2009-05-21 20:13   ` Stefan Richter
2009-05-21 20:33     ` David Miller [this message]
2009-05-21 21:35       ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090521.133304.10307675.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fenlason@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).