From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Miller <davem@davemloft.net>, Karsten Keil <isdn@linux-pingi.de>
Cc: Paul Moore <paul.moore@hp.com>,
Linux Networking Development Mailing List
<netdev@vger.kernel.org>, Chris Van Hoof <vanhoof@redhat.com>,
Clark Williams <williams@redhat.com>,
linux-security-module@vger.kernel.org
Subject: [PATCH 1/1] isdn: Use kernel_{send,recv}msg instead of open coding
Date: Thu, 21 May 2009 12:41:26 -0300 [thread overview]
Message-ID: <20090521154126.GH5956@ghostprotocols.net> (raw)
Reducing the number of direct users of sock_{recv,send}msg.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c
index abe5749..8caf40e 100644
--- a/drivers/isdn/mISDN/l1oip_core.c
+++ b/drivers/isdn/mISDN/l1oip_core.c
@@ -279,7 +279,6 @@ l1oip_socket_send(struct l1oip *hc, u8 localcodec, u8 channel, u32 chanmask,
int multi = 0;
u8 frame[len+32];
struct socket *socket = NULL;
- mm_segment_t oldfs;
if (debug & DEBUG_L1OIP_MSG)
printk(KERN_DEBUG "%s: sending data to socket (len = %d)\n",
@@ -352,10 +351,7 @@ l1oip_socket_send(struct l1oip *hc, u8 localcodec, u8 channel, u32 chanmask,
"= %d)\n", __func__, len);
hc->sendiov.iov_base = frame;
hc->sendiov.iov_len = len;
- oldfs = get_fs();
- set_fs(KERNEL_DS);
- len = sock_sendmsg(socket, &hc->sendmsg, len);
- set_fs(oldfs);
+ len = kernel_sendmsg(socket, &hc->sendmsg, len);
/* give socket back */
hc->socket = socket; /* no locking required */
@@ -661,7 +657,6 @@ l1oip_socket_thread(void *data)
int ret = 0;
struct msghdr msg;
struct iovec iov;
- mm_segment_t oldfs;
struct sockaddr_in sin_rx;
unsigned char recvbuf[1500];
int recvlen;
@@ -731,10 +726,7 @@ l1oip_socket_thread(void *data)
while (!signal_pending(current)) {
iov.iov_base = recvbuf;
iov.iov_len = sizeof(recvbuf);
- oldfs = get_fs();
- set_fs(KERNEL_DS);
- recvlen = sock_recvmsg(socket, &msg, sizeof(recvbuf), 0);
- set_fs(oldfs);
+ recvlen = kernel_recvmsg(socket, &msg, sizeof(recvbuf), 0);
if (recvlen > 0) {
l1oip_socket_parse(hc, &sin_rx, recvbuf, recvlen);
} else {
next reply other threads:[~2009-05-21 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 15:41 Arnaldo Carvalho de Melo [this message]
2009-05-21 22:14 ` [PATCH 1/1] isdn: Use kernel_{send,recv}msg instead of open coding David Miller
2009-05-21 23:49 ` David Miller
2009-05-22 1:34 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521154126.GH5956@ghostprotocols.net \
--to=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=vanhoof@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).