From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: isdn@linux-pingi.de, paul.moore@hp.com, netdev@vger.kernel.org,
vanhoof@redhat.com, williams@redhat.com,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 1/1] isdn: Use kernel_{send,recv}msg instead of open coding
Date: Thu, 21 May 2009 22:34:24 -0300 [thread overview]
Message-ID: <20090522013424.GP5956@ghostprotocols.net> (raw)
In-Reply-To: <20090521.164929.241809587.davem@davemloft.net>
Em Thu, May 21, 2009 at 04:49:29PM -0700, David Miller escreveu:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 21 May 2009 15:14:43 -0700 (PDT)
>
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Date: Thu, 21 May 2009 12:41:26 -0300
> >
> >> Reducing the number of direct users of sock_{recv,send}msg.
> >>
> >> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > Nice work, applied, thanks!
>
> Nevermind, I'm reverting, this doesn't even build:
>
> drivers/isdn/mISDN/l1oip_core.c: In function 'l1oip_socket_send':
> drivers/isdn/mISDN/l1oip_core.c:354: warning: passing argument 3 of 'kernel_sendmsg' makes pointer from integer without a cast
> drivers/isdn/mISDN/l1oip_core.c:354: error: too few arguments to function 'kernel_sendmsg'
> drivers/isdn/mISDN/l1oip_core.c: In function 'l1oip_socket_thread':
> drivers/isdn/mISDN/l1oip_core.c:729: warning: passing argument 3 of 'kernel_recvmsg' makes pointer from integer without a cast
> drivers/isdn/mISDN/l1oip_core.c:729: error: too few arguments to function 'kernel_recvmsg'
I should have said "not even compile tested".
Will understand stricter questioning in the future.
Damn, these are not present in at least the distro kernel build I
tried...
- Arnaldo
prev parent reply other threads:[~2009-05-22 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 15:41 [PATCH 1/1] isdn: Use kernel_{send,recv}msg instead of open coding Arnaldo Carvalho de Melo
2009-05-21 22:14 ` David Miller
2009-05-21 23:49 ` David Miller
2009-05-22 1:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522013424.GP5956@ghostprotocols.net \
--to=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=vanhoof@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).