Re: [RFC 1/2] net: Introduce recvmmsg socket syscall

[steve@chygwyn.com]

Hi,

On Fri, May 22, 2009 at 10:22:48AM +0300, Rémi Denis-Courmont wrote:
> On Thursday 21 May 2009 02:06:52 ext Arnaldo Carvalho de Melo wrote:
> > +       /*
> > +        * We may return less entries than requested (vlen) if the
> > +        * sock is non block and there aren't enough datagrams.
> > +        */
> > +       if (err == 0 || (err == -EAGAIN && (flags & MSG_DONTWAIT)))
> > +               return datagrams;
> >         return err;
> >  }
> 
> Could there be a situation whereby we receive one or more datagrams, then get 
> an error? How does userland get the datagrams then?
>
Normally you'd expect the call to return what it has read without an
error, and then the socket error would be picked up on the next call.
Need to check if sk->sk_error is being reset in the common code I
guess,

Steve.