Re: [PATCH 1/1] ethtool: Expose MDI-X status

Ben Hutchings
2009-05-26T16:02:52Z

On Tue, 2009-05-26 at 08:34 -0700, Chaitanya Lala wrote:
> Ben Hutchings wrote:
> > On Fri, 2009-05-22 at 10:18 -0700, Chaitanya Lala wrote:
> >
> >> The MDI-X status is a useful tool for diagnosing network
> >> connectivity issues. We expose MDI-X status as a tri-state value
> >> status which drivers can optionally implement.
> >>
> >> Signed-off-by: Chaitanya Lala <clala@riverbed.com>
> >> Signed-off-by: Arthur Jones <ajones@riverbed.com>
> >> ---
> >> ethtool-copy.h | 6 ++++++
> >> ethtool.c | 13 +++++++++++++
> >> 2 files changed, 19 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/ethtool-copy.h b/ethtool-copy.h
> >> index 3ca4e2c..d3e1524 100644
> >> --- a/ethtool-copy.h
> >> +++ b/ethtool-copy.h
> >> @@ -28,6 +28,7 @@ struct ethtool_cmd {
> >> __u16 speed_hi;
> >> __u16 reserved2;
> >> __u32 reserved[3];
> >> + __u8 is_mdix; /* Tri-state value to expose MDI-X */
> >> };
> >>
> > [...]
> >
> > No, you cannot change the size of this structure either.
> >
> Hi,
>
> In that case please suggest a way to do this.

There are 14 bytes at the end of the structure reserved for future
expansion. You could take one of them.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.