From: Benjamin LaHaise <bcrl@lhnet.ca>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Denys Fedoryschenko <denys@visp.net.lb>, netdev@vger.kernel.org
Subject: Re: regression: unregister_netdev() unusably slow
Date: Sun, 24 May 2009 17:44:33 -0400 [thread overview]
Message-ID: <20090524214433.GH24757@kvack.org> (raw)
In-Reply-To: <4A19BF39.4000305@cosmosbay.com>
On Sun, May 24, 2009 at 11:42:17PM +0200, Eric Dumazet wrote:
> (But vlan case might be litle bit more expensive than your case, since we call
> synchronize_net() three times (once in unregister_vlan_dev(), and twice in rollback_registered()
I did try commenting out the synchronize_net() calls in rollback_registered(),
but that had almost no effect on the rate of interface deletion. 50ms is
still way too expensive.
-ben
next prev parent reply other threads:[~2009-05-24 21:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 19:21 regression: unregister_netdev() unusably slow Benjamin LaHaise
2009-05-24 21:23 ` Denys Fedoryschenko
2009-05-24 21:37 ` Benjamin LaHaise
2009-05-24 21:42 ` Eric Dumazet
2009-05-24 21:44 ` Benjamin LaHaise [this message]
2009-05-24 22:07 ` Eric Dumazet
2009-05-24 22:12 ` Benjamin LaHaise
2009-05-24 22:47 ` Eric Dumazet
2009-05-25 0:00 ` Benjamin LaHaise
2009-05-25 5:22 ` Eric Dumazet
2009-05-25 8:04 ` Damien Wyart
2009-05-25 16:21 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090524214433.GH24757@kvack.org \
--to=bcrl@lhnet.ca \
--cc=dada1@cosmosbay.com \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).