* [PATCH 2/3] myri10ge: drop myri10ge_lro module parameter
@ 2009-05-24 15:27 Brice Goglin
2009-05-25 7:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Brice Goglin @ 2009-05-24 15:27 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Network Development list
Drop the myri10ge_lro module parameter now that we have ethtool
to enable/disable LRO in the myri10ge driver.
Signed-off-by: Brice Goglin <brice@myri.com>
---
drivers/net/myri10ge/myri10ge.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index d317011..675f677 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -327,10 +327,6 @@ static int myri10ge_debug = -1; /* defaults above */
module_param(myri10ge_debug, int, 0);
MODULE_PARM_DESC(myri10ge_debug, "Debug level (0=none,...,16=all)");
-static int myri10ge_lro = 1;
-module_param(myri10ge_lro, int, S_IRUGO);
-MODULE_PARM_DESC(myri10ge_lro, "Enable large receive offload");
-
static int myri10ge_lro_max_pkts = MYRI10GE_LRO_MAX_PKTS;
module_param(myri10ge_lro_max_pkts, int, S_IRUGO);
MODULE_PARM_DESC(myri10ge_lro_max_pkts,
@@ -3918,8 +3914,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (dac_enabled)
netdev->features |= NETIF_F_HIGHDMA;
- if (myri10ge_lro)
- netdev->features |= NETIF_F_LRO;
+ netdev->features |= NETIF_F_LRO;
/* make sure we can get an irq, and that MSI can be
* setup (if available). Also ensure netdev->irq
--
1.6.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] myri10ge: drop myri10ge_lro module parameter
2009-05-24 15:27 [PATCH 2/3] myri10ge: drop myri10ge_lro module parameter Brice Goglin
@ 2009-05-25 7:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-25 7:36 UTC (permalink / raw)
To: brice; +Cc: netdev
From: Brice Goglin <brice@myri.com>
Date: Sun, 24 May 2009 17:27:51 +0200
> Drop the myri10ge_lro module parameter now that we have ethtool
> to enable/disable LRO in the myri10ge driver.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-25 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-24 15:27 [PATCH 2/3] myri10ge: drop myri10ge_lro module parameter Brice Goglin
2009-05-25 7:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).