From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: shemminger@vyatta.com, linux-m68k@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion
Date: Mon, 25 May 2009 22:44:01 -0700 (PDT) [thread overview]
Message-ID: <20090525.224401.11926225.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0905261243230.22373@loopy.telegraphics.com.au>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Tue, 26 May 2009 12:50:12 +1000 (EST)
>
> Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding
> 8390.o to the link. That meant that lib8390.c was included twice, once in
> mac8390.c and once in 8390.c, subject to different macros. This patch
> reverts that by avoiding the wrappers in 8390.c. They seem to be of no
> value since COMPAT_NET_DEV_OPS is going away soon.
>
> Tested with a Kinetics EtherPort card.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Patch applied, thanks.
next prev parent reply other threads:[~2009-05-26 5:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0905260116120.18180@loopy.telegraphics.com.au>
2009-05-26 2:50 ` [PATCH] mac8390: fix regression caused during net_device_ops conversion Finn Thain
2009-05-26 5:44 ` David Miller [this message]
[not found] ` <10f740e80905270149q2b906d53u8bf71b7d382a57a3@mail.gmail.com>
2009-05-28 5:26 ` [PATCH] mac8390: fix regression caused during net_device_ops conversion, take 2 Finn Thain
2009-05-28 5:33 ` David Miller
2009-05-28 12:05 ` [PATCH] mac8390: fix build with NET_POLL_CONTROLLER Finn Thain
2009-05-29 8:56 ` David Miller
2009-05-29 12:03 ` Jiri Pirko
2009-05-29 15:25 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525.224401.11926225.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).