From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: txq_trans_update() helper
Date: Mon, 25 May 2009 22:58:19 -0700 (PDT) [thread overview]
Message-ID: <20090525.225819.119681427.davem@davemloft.net> (raw)
In-Reply-To: <4A1B84AD.1040707@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 26 May 2009 07:57:01 +0200
> David Miller a écrit :
>> Closing brace here has strange indentation, which doesn't match
>> the statement of the openning brace.
>>
>> Please fix this, thanks.
>
> Oops you are right, this is a leftover.
>
> [PATCH] net: txq_trans_update() helper
>
> We would like to get rid of netdev->trans_start = jiffies; that about all net
> drivers have to use in their start_xmit() function, and use txq->trans_start
> instead.
>
> This can be done generically in core network, as suggested by David.
>
> Some devices, (particularly loopback) dont need trans_start update, because
> they dont have transmit watchdog. We could add a new device flag, or rely
> on fact that txq->tran_start can be updated is txq->xmit_lock_owner is
> different than -1. Use a helper function to hide our choice.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks a lot Eric.
prev parent reply other threads:[~2009-05-26 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 19:47 [PATCH] net: tx scalability works : trans_start Eric Dumazet
2009-05-18 3:57 ` David Miller
2009-05-18 7:21 ` Eric Dumazet
2009-05-18 22:11 ` David Miller
2009-05-26 5:37 ` [PATCH] net: txq_trans_update() helper Eric Dumazet
2009-05-26 5:38 ` David Miller
2009-05-26 5:57 ` Eric Dumazet
2009-05-26 5:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525.225819.119681427.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).