netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com
Subject: Re: [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations
Date: Tue, 26 May 2009 20:38:10 -0700 (PDT)	[thread overview]
Message-ID: <20090526.203810.50281143.davem@davemloft.net> (raw)
In-Reply-To: <20090527005445.28535.9069.stgit@localhost.localdomain>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 26 May 2009 17:54:45 -0700

> The counter rx_hdr_split was meant to be a debug counter.  As such it
> should only be enabled when debugging.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

I disagree with this change.

Any statistic is useful for diagnosing problems by users, and
if you hide it behind DEBUG then users never see the facility.

Either it's unconditionally in the driver or it's unconditionally out.
I say keep it in :-)


  reply	other threads:[~2009-05-27  3:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27  0:54 [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load Jeff Kirsher
2009-05-27  0:54 ` [net-next-2.6 PATCH 2/4] ixgbe: fix driver loading with unsupported module on 82598 Jeff Kirsher
2009-05-27  1:28   ` Ben Hutchings
2009-05-27  3:41     ` David Miller
2009-05-27  0:54 ` [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations Jeff Kirsher
2009-05-27  3:38   ` David Miller [this message]
2009-05-27 11:16     ` Ben Hutchings
2009-05-27 20:52       ` David Miller
2009-05-29  0:01         ` Duyck, Alexander H
2009-05-29  0:04           ` David Miller
2009-05-27  0:55 ` [net-next-2.6 PATCH 4/4] ixgbe: Remove device ID 0x10d8 Jeff Kirsher
2009-05-27  3:40   ` David Miller
2009-05-27  3:40 ` [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526.203810.50281143.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).