From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] gianfar: fix babbling rx error event bug Date: Tue, 26 May 2009 20:48:15 -0700 (PDT) Message-ID: <20090526.204815.185454308.davem@davemloft.net> References: <1243389156-1668-1-git-send-email-Xiaotian.Feng@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org To: Xiaotian.Feng@windriver.com Return-path: In-Reply-To: <1243389156-1668-1-git-send-email-Xiaotian.Feng@windriver.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org List-Id: netdev.vger.kernel.org From: Xiaotian Feng Date: Wed, 27 May 2009 09:52:36 +0800 > Gianfar interrupt handler uses IEVENT_ERR_MASK to check and handle errors. > Babbling RX error (IEVENT_BABR) should be included in IEVENT_ERROR_MASK. > Otherwise if BABR is raised, it never gets handled nor cleared, and an > interrupt storm results. This has been observed to happen on sending a > burst of ethernet frames to a gianfar based board. > > Signed-off-by: Xiaotian Feng Patch applied, thanks.