From: Arnd Bergmann <arnd@arndb.de>
To: David Miller <davem@davemloft.net>
Cc: devicetree-discuss@ozlabs.org, netdev@vger.kernel.org,
linuxppc-dev@ozlabs.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver
Date: Tue, 26 May 2009 10:42:05 +0100 [thread overview]
Message-ID: <200905261042.05967.arnd@arndb.de> (raw)
In-Reply-To: <20090526.022508.238274281.davem@davemloft.net>
On Tuesday 26 May 2009, David Miller wrote:
> It's such a baroque thing, there is no reason to set it at all if you
> ask me. It's only use is to allow ISA and similar primitive bus
> devices to have their I/O ports changed via ifconfig.
My original comment was about the fact that sja1000 was doing
dev->base_addr = (unsigned long)ioremap(phys_addr, size), I didn't
even think about SIOCGIFMAP and command line overrides, but that
surely makes it worse and the driver should be changed to
store the virtual register address in its private data structure.
drivers/net/fec.c seems to have the same problem, which manifests
in a number of ugly casts and direct pointer dereferences in places
where it should do writel() or out_be32().
Arnd <><
next prev parent reply other threads:[~2009-05-26 9:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 14:46 [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver Wolfgang Grandegger
[not found] ` <4A16BAAE.3070401-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-05-22 15:08 ` Grant Likely
[not found] ` <fa686aa40905220808kecd06cdqb570b78ca97f0ca6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-23 6:29 ` Wolfgang Grandegger
2009-05-23 16:44 ` Wolfgang Grandegger
2009-05-25 6:53 ` Grant Likely
2009-05-25 8:15 ` Wolfgang Grandegger
2009-05-23 11:15 ` Arnd Bergmann
[not found] ` <200905231315.57016.arnd-r2nGTMty4D4@public.gmane.org>
2009-05-23 16:51 ` Wolfgang Grandegger
2009-05-24 22:27 ` Arnd Bergmann
2009-05-25 6:58 ` Wolfgang Grandegger
2009-05-26 9:10 ` Arnd Bergmann
[not found] ` <200905261010.31364.arnd-r2nGTMty4D4@public.gmane.org>
2009-05-26 9:25 ` David Miller
2009-05-26 9:42 ` Arnd Bergmann [this message]
2009-05-26 11:20 ` Sascha Hauer
2009-05-26 14:23 ` Wolfgang Grandegger
2009-05-30 17:59 ` Wolfgang Grandegger
2009-05-26 9:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905261042.05967.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@ozlabs.org \
--cc=gerg@uclinux.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).